Fixing app crashing when locale not null #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DiggesT
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem was
export const i18n = i18next.use...is not creating a new instance (i18nhad typeany, meansi18n.changeLanguage()can't be call). We should usei18next.createInstance.Also i tested it with my project, and there is was a problem with other global instance of
i18next(used in my app). One of the instances was dominant, so the second didn't work correctly. To avoid it we should useI18nextProviderto separate from each other.Solution for #24 and #25.
Please review and test it before merge.
Hope it help.