Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AzureCommentReporter not adding comments to PR #4149

Merged

Conversation

lukelloyd1985
Copy link
Contributor

@lukelloyd1985 lukelloyd1985 commented Oct 16, 2024

Fixes #4132

Proposed Changes

Use SYSTEM_PULLREQUEST_SOURCEREPOSITORYURI instead of BUILD_REPOSITORY_ID to locate the correct repository referenced in the PR.

Fallback to BUILD_REPOSITORY_ID if SYSTEM_PULLREQUEST_SOURCEREPOSITORYURI isn't available to avoid a breaking change.

Readiness Checklist

Author/Contributor

  • Add entry to the CHANGELOG listing the change and linking to the corresponding issue (if appropriate)
  • If documentation is needed for this change, has that been included in this pull request

Reviewing Maintainer

  • Label as breaking if this is a large fundamental change
  • Label as either automation, bug, documentation, enhancement, infrastructure, or performance

@echoix
Copy link
Collaborator

echoix commented Oct 16, 2024

Ill still let @nvuillam go through as I didn't follow attentively.

@lukelloyd1985
Copy link
Contributor Author

@nvuillam, are we able to merge this PR and hopefully a new image creation succeeds 🤞🏻

@nvuillam nvuillam merged commit c116434 into oxsecurity:main Oct 17, 2024
6 checks passed
@nvuillam
Copy link
Member

@lukelloyd1985 trivy is still unstable... but some flavor beta images has been successfully created and uploaded :)

https://github.com/oxsecurity/megalinter/actions/runs/11383553685

@lukelloyd1985 lukelloyd1985 deleted the 4132-azure-comment-reporter-project branch October 17, 2024 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AzureCommentReporter fails when using central yaml pipeline repo
3 participants