-
-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(linter): add codespell linter #4143
Draft
ideaship
wants to merge
3
commits into
oxsecurity:main
Choose a base branch
from
ideaship:rl_add_codespell
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ideaship
requested review from
nvuillam,
echoix,
bdovaz and
Kurt-von-Laven
as code owners
October 16, 2024 08:13
ideaship
force-pushed
the
rl_add_codespell
branch
from
October 16, 2024 08:44
f69ce60
to
f2c2fa3
Compare
ideaship
force-pushed
the
rl_add_codespell
branch
from
October 16, 2024 08:55
f2c2fa3
to
04dd611
Compare
ideaship
force-pushed
the
rl_add_codespell
branch
from
October 16, 2024 12:09
04dd611
to
0577625
Compare
Add the codespell linter which uses a dictionary of common misspellings and ignores unknown words. Signed-off-by: Roger Luethi <roger.luethi@bisdn.de>
ideaship
force-pushed
the
rl_add_codespell
branch
from
October 16, 2024 13:52
0577625
to
41077c0
Compare
@nvuillam The PR I created is failing for reasons that are not obvious to me. I will hopefully get around to take another look tomorrow. Hints welcome. |
nvuillam
reviewed
Oct 16, 2024
@@ -211,3 +211,39 @@ linters: | |||
dockerfile: | |||
- FROM lycheeverse/lychee:latest-alpine AS lychee | |||
- COPY --link --from=lychee /usr/local/bin/lychee /usr/bin/ | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks quality :)
Try if this helps workflow find test files. Signed-off-by: Roger Luethi <roger.luethi@bisdn.de>
Signed-off-by: Roger Luethi <roger.luethi@bisdn.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the codespell linter which uses a dictionary of common misspellings and ignores unknown words.
Fixes #4140
Proposed Changes
Add the codespell linter which uses a dictionary of common misspellings and ignores unknown words.
Readiness Checklist
Author/Contributor
Reviewing Maintainer
breaking
if this is a large fundamental changeautomation
,bug
,documentation
,enhancement
,infrastructure
, orperformance