Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump bindgen to 0.71 in hope to fix compilation on Windows with recent clang. IIUC, latest bindgen should not have that problem.
I ran into 2 issues when bumping the crate:
ABI checks that referenced either private fields or out-of-scope structs:
I fixed it by patching those blocks with a
use crate::internal::*;
and getting rid of therb_sys__Opaque__
prefix. Not sure what underlying change made this a problem though.Missing
proc_macro2::Literal::c_string
when testing against magnus. Hence the proc_macro2 bump.With those changes, magnus tests pass on my machine. Let's see what CI says.