Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warning by dev/release profiles from member Cargo.toml to workspace Cargo.toml. #13

Merged
merged 1 commit into from
May 27, 2021

Conversation

luqmana
Copy link
Contributor

@luqmana luqmana commented May 27, 2021

Clear up the warning about "profiles for the non root package will be ignored" by moving these to the workspace root.

If we need to, we can add specific workspace member overrides though that does come with the limitation that you can't specify panic, lto or rpath settings. Another limitation is if we publish one of the binary workspace members then cargo install does would not use the workspace root profile settings (details).

@smklein
Copy link
Contributor

smklein commented May 27, 2021

Clear up the warning about "profiles for the non root package will be ignored" by moving these to the workspace root.

If we need to, we can add specific workspace member overrides though that does come with the limitation that you can't specify panic, lto or rpath settings. Another limitation is if we publish one of the binary workspace members then cargo install does would not use the workspace root profile settings (details).

This might be a bit overkill, what happens if we define these profiles in the workspace and the non-root packages? Would that resolve the cargo install case?

@luqmana
Copy link
Contributor Author

luqmana commented May 27, 2021

Clear up the warning about "profiles for the non root package will be ignored" by moving these to the workspace root.
If we need to, we can add specific workspace member overrides though that does come with the limitation that you can't specify panic, lto or rpath settings. Another limitation is if we publish one of the binary workspace members then cargo install does would not use the workspace root profile settings (details).

This might be a bit overkill, what happens if we define these profiles in the workspace and the non-root packages? Would that resolve the cargo install case?

In that case you'll get the same warning again about the profile settings being ignored for those non-root packages.

@luqmana luqmana merged commit da3a1fc into master May 27, 2021
@luqmana luqmana deleted the workspace-profiles branch May 27, 2021 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants