Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mwocp68: add commands for firmware update #16

Merged
merged 5 commits into from
Nov 25, 2024
Merged

mwocp68: add commands for firmware update #16

merged 5 commits into from
Nov 25, 2024

Conversation

bcantrill
Copy link
Contributor

@bcantrill bcantrill commented Nov 22, 2024 •
edited
Loading

Draft comments:

This adds some additional PMBus support for the MWOCP68-3600 series,
specifically around the commands necessary to support firmware update.
(This also performs some minor cleanup, bumping the Rust version
to 1.84 and fixing the resulting clippy warnings.)

@mkeeter
Copy link
Contributor

mkeeter commented Nov 22, 2024

The CI failures are because we've set an MSRV of 1.57 (Dec 2, 2021) in ci.yaml, which doesn't support vars in format strings. I'd be fine bumping that to something a little newer 😆

@bcantrill bcantrill marked this pull request as ready for review November 25, 2024 00:54
@bcantrill bcantrill changed the title cleanup + add support for mwocp68 update mwocp68: add commands for firmware update Nov 25, 2024
@bcantrill bcantrill merged commit 44568ce into master Nov 25, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkeeter mkeeter mkeeter left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bcantrill @mkeeter