Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server: Log HTTP response code as u16 #1269

Merged
merged 2 commits into from
Feb 28, 2025
Merged

server: Log HTTP response code as u16 #1269

merged 2 commits into from
Feb 28, 2025

Conversation

wfchandler
Copy link
Contributor

Currently HTTP response codes are generally logged as strings, which is a bit unintuitive as these are integers.

Log the response code as a numeric value.

Currently HTTP response codes are generally logged as strings, which is
a bit unintuitive as these are integers.

Log the response code as a numeric value.
@davepacheco
Copy link
Collaborator

Thanks for this. Interestingly, I see that of the four cases you changed:

It's kind of nice to get the reason string in this last case but we mostly weren't getting that anyway (this was kind of an edge case) so this seems like no reason not to make this change.

Could you update the changelog to mention this? Then we can land this.

@wfchandler
Copy link
Contributor Author

Thanks @davepacheco, I've updated the changelog.

@davepacheco davepacheco merged commit b1593b9 into main Feb 28, 2025
10 checks passed
@davepacheco davepacheco deleted the wc/numeric-rc branch February 28, 2025 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants