Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(prettier): Update tasks/prettier to correctly handle snapshots #8337

Merged
merged 4 commits into from
Jan 8, 2025

Conversation

leaysgur
Copy link
Contributor

@leaysgur leaysgur commented Jan 8, 2025

I refactored the code in tasks/prettier_conformance primarily to make the output more readable when using --filter.

But I also discovered that our previous implementation did not correctly handle Prettier's behavior of adding a blank line at the EOF.

In addition, I resolved a problem where test specs that used patterns like runFormatTest(_, parsers) were unable to locate the correct snapshot output.

As a result, compatibility has also improved slightly. 😉

Copy link

graphite-app bot commented Jan 8, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added A-prettier Area - Prettier C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Jan 8, 2025
Copy link

codspeed-hq bot commented Jan 8, 2025

CodSpeed Performance Report

Merging #8337 will not alter performance

Comparing p/tasks (d59ef64) with main (a76dfae)

Summary

✅ 29 untouched benchmarks

@leaysgur leaysgur marked this pull request as ready for review January 8, 2025 08:50
@Boshen
Copy link
Member

Boshen commented Jan 8, 2025

Nice!

@Boshen Boshen merged commit 8e3eed7 into main Jan 8, 2025
30 checks passed
@Boshen Boshen deleted the p/tasks branch January 8, 2025 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-prettier Area - Prettier C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants