Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(minifier): disable RemoveUnusedCode #8243

Merged
merged 1 commit into from
Jan 4, 2025

Conversation

Boshen
Copy link
Member

@Boshen Boshen commented Jan 4, 2025

A lot of edge cases fail in test262 and monitor-oxc.

@github-actions github-actions bot added A-minifier Area - Minifier C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Jan 4, 2025
Copy link
Member Author

Boshen commented Jan 4, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Boshen Boshen changed the base branch from 01-04-fix_minifier_fix_panic_in_peephole_minimize_conditions_ to graphite-base/8243 January 4, 2025 07:56
@Boshen Boshen force-pushed the graphite-base/8243 branch from c6169c8 to d2f8eaa Compare January 4, 2025 08:01
@Boshen Boshen force-pushed the 01-04-chore_minifier_disable_removeunusedcode_ branch from c23e2f6 to 2052b35 Compare January 4, 2025 08:01
@Boshen Boshen changed the base branch from graphite-base/8243 to main January 4, 2025 08:02
@Boshen Boshen force-pushed the 01-04-chore_minifier_disable_removeunusedcode_ branch from 2052b35 to cb14f3d Compare January 4, 2025 08:02
Copy link

codspeed-hq bot commented Jan 4, 2025

CodSpeed Performance Report

Merging #8243 will improve performances by 9.86%

Comparing 01-04-chore_minifier_disable_removeunusedcode_ (ce2b5a9) with main (d2f8eaa)

Summary

⚡ 3 improvements
✅ 26 untouched benchmarks

Benchmarks breakdown

Benchmark main 01-04-chore_minifier_disable_removeunusedcode_ Change
minifier[antd.js] 235.7 ms 215.6 ms +9.3%
minifier[react.development.js] 1.6 ms 1.4 ms +9.86%
minifier[typescript.js] 754.8 ms 720.2 ms +4.79%

@Boshen Boshen force-pushed the 01-04-chore_minifier_disable_removeunusedcode_ branch from cb14f3d to ad5da7d Compare January 4, 2025 08:44
Copy link

graphite-app bot commented Jan 4, 2025

Merge activity

A lot of edge cases fail in test262 and monitor-oxc.
@Boshen Boshen force-pushed the 01-04-chore_minifier_disable_removeunusedcode_ branch from ad5da7d to ce2b5a9 Compare January 4, 2025 08:49
@graphite-app graphite-app bot merged commit ce2b5a9 into main Jan 4, 2025
25 checks passed
@graphite-app graphite-app bot deleted the 01-04-chore_minifier_disable_removeunusedcode_ branch January 4, 2025 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-minifier Area - Minifier C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant