Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): Publish diagnostics on open for all run modes except disabled #6965

Merged

Conversation

nrayburn-tech
Copy link
Collaborator

No description provided.

Copy link

graphite-app bot commented Oct 27, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added A-editor Area - Editor and Language Server C-bug Category - Bug labels Oct 27, 2024
@nrayburn-tech
Copy link
Collaborator Author

Should the commit scope for this be editor or language_server? I tried language_server with #6968, but it tagged the area as editor still. So, not really sure which this should be.

@Boshen Boshen merged commit 6cb1973 into oxc-project:main Oct 28, 2024
14 checks passed
Orenbek pushed a commit to Orenbek/oxc that referenced this pull request Oct 28, 2024
@nrayburn-tech nrayburn-tech deleted the always-publish-diagnostics-on-open branch November 18, 2024 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-editor Area - Editor and Language Server C-bug Category - Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants