Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ast): move custom types .d.ts file #6931

Merged
merged 1 commit into from
Oct 26, 2024

Conversation

overlookmotel
Copy link
Collaborator

@overlookmotel overlookmotel commented Oct 26, 2024

We have a few manually-defined TS types in oxc_ast crate. Move that .d.ts file out of src folder, and name it more descriptively.

Copy link

graphite-app bot commented Oct 26, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Collaborator Author

overlookmotel commented Oct 26, 2024

@github-actions github-actions bot added A-ast Area - AST A-ast-tools Area - AST tools C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Oct 26, 2024
@overlookmotel overlookmotel marked this pull request as ready for review October 26, 2024 14:26
@overlookmotel overlookmotel force-pushed the 10-26-refactor_ast_move_custom_types_.d.ts_file branch from 4483f89 to a103918 Compare October 26, 2024 14:28
Copy link

codspeed-hq bot commented Oct 26, 2024

CodSpeed Performance Report

Merging #6931 will not alter performance

Comparing 10-26-refactor_ast_move_custom_types_.d.ts_file (4483f89) with main (4cf0085)

Summary

✅ 30 untouched benchmarks

@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Oct 26, 2024
Copy link
Member

Boshen commented Oct 26, 2024

Merge activity

  • Oct 26, 1:09 PM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Oct 26, 1:09 PM EDT: A user added this pull request to the Graphite merge queue.
  • Oct 26, 1:16 PM EDT: A user merged this pull request with the Graphite merge queue.

We have a few manually-defined TS types in `oxc_ast` crate. Move that `.d.ts` file out of `src` folder, and name it more descriptively.
@Boshen Boshen force-pushed the 10-26-refactor_napi_move_custom_types_to_bottom_of_file branch from 1b11cf4 to 9926990 Compare October 26, 2024 17:11
@Boshen Boshen force-pushed the 10-26-refactor_ast_move_custom_types_.d.ts_file branch from a103918 to fc07458 Compare October 26, 2024 17:11
Base automatically changed from 10-26-refactor_napi_move_custom_types_to_bottom_of_file to main October 26, 2024 17:15
@graphite-app graphite-app bot merged commit fc07458 into main Oct 26, 2024
16 checks passed
@graphite-app graphite-app bot deleted the 10-26-refactor_ast_move_custom_types_.d.ts_file branch October 26, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue A-ast Area - AST A-ast-tools Area - AST tools C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants