refactor(linter): clean up Fixer and Message #5308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
DonIsaac
commented
Aug 28, 2024
•
DonIsaac
commented
- refactor(linter): clean up Fixer and Message
- perf(linter): replace sort_by_key with sort_unstable_by_key in fixer
This stack of pull requests is managed by Graphite. Learn more about stacking. |
DonIsaac
added
C-performance
Graphite App
CodSpeed Performance ReportMerging #5308 will not alter performanceComparing Summary
|
camc314
approved these changes
Aug 28, 2024
Merge activity
|
- refactor(linter): clean up Fixer and Message - perf(linter): replace sort_by_key with sort_unstable_by_key in fixer
DonIsaac
force-pushed
the
don/08-28-chore_bench_include_fixers_in_linter_benchmarks
branch
from
d672c06
to
270fc53
Compare
DonIsaac
force-pushed
the
don/08-28-refactor_linter_clean_up_fixer_and_message
branch
from
57756d0
to
fa1d460
Compare
Base automatically changed from
don/08-28-chore_bench_include_fixers_in_linter_benchmarks
to
main
August 28, 2024 23:24
graphite-app
bot
deleted the
don/08-28-refactor_linter_clean_up_fixer_and_message
branch
This was referenced Aug 29, 2024
Closed
Closed
Closed
Merged
Boshen
added a commit
that referenced
this pull request
Aug 29, 2024
## [0.9.1] - 2024-08-29 ### Features - 6633972 linter: Add fixer for `no-empty` (#5276) (camc314) - a58e448 linter/eslint: Add fixer to `no-var` (#5144) (camc314) - a6e9769 linter/jsx-a11y: Add `label-has-associated-control` (#5163) (Billy Levin) - c8e8532 linter/unicorn: Add fixer to `throw-new-error` (#5275) (camc314) - 7ccde4b linter/unicorn: Add fixer to `prefer-date-now` (#5147) (camc314) ### Bug Fixes - 76e86f8 linter: Eslint-plugin-unicorn prefer-spread wrong linter suggestion on variables of type string (#5265) (Arian94) - b39544e linter/jest: Fixer for `prefer-jest-mocked` creates invalid LHS expressions (#5243) (camc314) - 9953fa5 linter/no-null: Incorrect fixer for `NullLiteral` within `ReturnStatement` (#5247) (Dunqing) - 318479e linter/no-unused-vars: Mark the class/function in the new expression as used (#5306) (magic-akari) ### Refactor - fa1d460 linter: Clean up Fixer and Message (#5308) (DonIsaac) Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.