chore(napi): Refactor async parsing functions to remove tokio dependency #4049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added `use napi::{bindgen_prelude::AsyncTask, Task}` to handle async tasks without tokio.
- Introduced `ResolveTask` struct implementing `Task` for asynchronous parsing.
- Replaced `parse_sync` function implementation with `parse_with_return` to reuse code.
- Refactored `parse_async` to use `AsyncTask` and `ResolveTask` for async parsing.
- Removed tokio dependency by avoiding `tokio::spawn` and using `AsyncTask` for async operations.
This refactor enhances code readability and removes the dependency on tokio, streamlining the async task handling within the napi framework.
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
CodSpeed Performance ReportMerging #4049 will not alter performanceComparing Summary
|
|
|
Another part of the code also needs modification: oxc/napi/parser/src/module_lexer.rs Line 144 in e32b4bc |
- Simplified parse_with_return function to eliminate unnecessary lifetime annotation and unnecessary borrowing of variables. - Updated span.source_text usage to directly reference parameters instead of borrowing.
- Changed module_lexer function parameters from String and Option<ParserOptions> to &str and &ParserOptions, using unwrap_or_default for the options parameter.
- Updated module_lexer_sync function to call module_lexer with &source_text and &options.
- Introduced napi::{bindgen_prelude::AsyncTask, Task}, and implemented the Task trait for the ResolveTask struct.
- Added support for AsyncTask<ResolveTask> in the module_lexer_async function to handle asynchronous tasks.
Boshen
approved these changes
Jul 4, 2024
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4044
use napi::{bindgen_prelude::AsyncTask, Task}to handle async tasks without tokio.ResolveTaskstruct implementingTaskfor asynchronous parsing.parse_syncfunction implementation withparse_with_returnto reuse code.parse_asyncto useAsyncTaskandResolveTaskfor async parsing.tokio::spawnand usingAsyncTaskfor async operations.This refactor enhances code readability and removes the dependency on tokio, streamlining the async task handling within the napi framework.