-
-
Notifications
You must be signed in to change notification settings - Fork 501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(sourcemap): using binary search to search original position #3360
refactor(sourcemap): using binary search to search original position #3360
Conversation
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
CodSpeed Performance ReportMerging #3360 will degrade performances by 13.38%Comparing Summary
Benchmarks breakdown
|
Do we need to fix the performance issue 😅 |
In my view, ultimately the best solution is to be calculating UTF16/line-column spans in the lexer (as discussed in #959). That should be the most performant way to support sourcemaps' use case. Unclear when we're going to do that, but we could leave worrying about performance until then if we think it's not urgent to fix the perf right now. |
Yeah. The performance is little regression at rolldown, we could skip it at now. |
Wait ... can we add some test cases? |
Merge activity
|
The ast span is not ordering at rolldown, eg the module original ast is
a,b,c
, after mutate could beb,c,a
. So here revert changes from here.