Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(linter): keep rules disabled if the rule is not enabled in the config #2031

Merged

Conversation

Boshen
Copy link
Member

@Boshen Boshen commented Jan 15, 2024

relates #1969

Copy link
Member Author

Boshen commented Jan 15, 2024

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@github-actions github-actions bot added A-linter Area - Linter A-cli Area - CLI labels Jan 15, 2024
@Boshen Boshen changed the title fix(linter): keep rules disabled if the rule is not enabled fix(linter): keep rules disabled if the rule is not enabled in the config Jan 15, 2024
Copy link

codspeed-hq bot commented Jan 15, 2024

CodSpeed Performance Report

Merging #2031 will not alter performance

Comparing 01-15-fix_linter_keep_rules_disabled_if_the_rule_is_not_enabled (b08e60d) with main (3490111)

Summary

✅ 14 untouched benchmarks

@Boshen Boshen force-pushed the 01-15-fix_linter_keep_rules_disabled_if_the_rule_is_not_enabled branch from 2a6284d to b08e60d Compare January 15, 2024 05:29
@Boshen Boshen enabled auto-merge (squash) January 15, 2024 05:29
@Boshen Boshen merged commit 68606c4 into main Jan 15, 2024
16 checks passed
@Boshen Boshen deleted the 01-15-fix_linter_keep_rules_disabled_if_the_rule_is_not_enabled branch January 15, 2024 05:32
IWANABETHATGUY pushed a commit to IWANABETHATGUY/oxc that referenced this pull request May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-cli Area - CLI A-linter Area - Linter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant