-
-
Notifications
You must be signed in to change notification settings - Fork 514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(linter): eslint-plugin-jsx-a11y role-has-required-aria-props rule #1881
feat(linter): eslint-plugin-jsx-a11y role-has-required-aria-props rule #1881
Conversation
CodSpeed Performance ReportMerging #1881 will degrade performances by 6.49%Comparing Summary
Benchmarks breakdown
|
crates/oxc_linter/src/rules/jsx_a11y/role_has_required_aria_props.rs
Outdated
Show resolved
Hide resolved
crates/oxc_linter/src/rules/jsx_a11y/role_has_required_aria_props.rs
Outdated
Show resolved
Hide resolved
crates/oxc_linter/src/rules/jsx_a11y/role_has_required_aria_props.rs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one last comment then this is good to go!
7a2f75c
to
16111e0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you!
16111e0
to
a4b00a3
Compare
Base branch was modified
9d9a43c
to
a42ef7d
Compare
@camc314 |
Sorry i meant to merge this 🙂 . i think the code speed drop is fine - it looks slightly buggy e.g. #1965 (comment) |
…c-project#1881) partof: oxc-project#1141 Based on: - doc: https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/blob/main/docs/rules/role-has-required-aria-props.md - code: https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/blob/main/src/rules/role-has-required-aria-props.js - test: https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/blob/main/__tests__/src/rules/role-has-required-aria-props-test.js
partof: #1141