Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eslint-plugin-unicorn(prefer-spread) is triggering on strings #5248

Closed
tylerlaprade opened this issue Aug 27, 2024 · 0 comments · Fixed by #5265
Closed

eslint-plugin-unicorn(prefer-spread) is triggering on strings #5248

tylerlaprade opened this issue Aug 27, 2024 · 0 comments · Fixed by #5265
Labels
C-bug Category - Bug good first issue Experience Level - Good for newcomers

Comments

@tylerlaprade
Copy link 

const x = "foo";
x.concat(x);

This should not be flagged as x is not an array.
@tylerlaprade tylerlaprade added the C-bug Category - Bug label Aug 27, 2024
@Boshen Boshen added the good first issue Experience Level - Good for newcomers label Aug 27, 2024
@Arian94 Arian94 mentioned this issue Aug 27, 2024
Merged
camc314 pushed a commit that referenced this issue Aug 28, 2024
@Arian94
fix(linter): eslint-plugin-unicorn prefer-spread wrong linter suggest…
76e86f8 
…ion on variables of type string (#5265)

fixes #5248.

Similar issue found in here:
sindresorhus/eslint-plugin-unicorn#1147
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-bug Category - Bug good first issue Experience Level - Good for newcomers
Projects
None yet
Milestone
No milestone
2 participants
@Boshen @tylerlaprade