feat(linter): add fixer for unicorn/prefer-optional-catch-binding (#4867

)

crates/oxc_linter/src/rules/unicorn/prefer_optional_catch_binding.rs

@@ -39,7 +39,7 @@ declare_oxc_lint!(
     /// ```
     PreferOptionalCatchBinding,
     style,
-    pending
+    fix
 );
 
 impl Rule for PreferOptionalCatchBinding {
@@ -51,7 +51,31 @@ impl Rule for PreferOptionalCatchBinding {
         if references_count != 0 {
             return;
         }
-        ctx.diagnostic(prefer_optional_catch_binding_diagnostic(catch_param.pattern.span()));
+        let Some(parent_node) = ctx.nodes().parent_node(node.id()) else {
+            return;
+        };
+        let AstKind::CatchClause(catch_clause) = parent_node.kind() else {
+            return;
+        };
+        ctx.diagnostic_with_fix(
+            prefer_optional_catch_binding_diagnostic(catch_param.pattern.span()),
+            |fixer| {
+                let mut start = catch_clause.span().start + 5;
+                let total_param = Span::new(start, catch_param.span().start);
+                let total_param_value = ctx.source_range(total_param);
+                let plus_space: u32 = total_param_value
+                    .as_bytes()
+                    .iter()
+                    .position(|x| !x.is_ascii_whitespace())
+                    .unwrap_or(0)
+                    .try_into()
+                    .unwrap();
+                start += plus_space;
+                let end = catch_clause.body.span().start;
+                let span = Span::new(start, end);
+                fixer.delete(&span)
+            },
+        );
     }
 }
 
@@ -110,5 +134,21 @@ fn test() {
         r"try {} catch ({cause: {message}}) {}",
     ];
 
-    Tester::new(PreferOptionalCatchBinding::NAME, pass, fail).test_and_snapshot();
+    let fix = vec![
+        (r"try {} catch (_) {}", r"try {} catch {}"),
+        (r"try {} catch (theRealErrorName) {}", r"try {} catch {}"),
+        (
+            r"try    {    } catch    (e)
+			  	  {    }",
+            r"try    {    } catch    {    }",
+        ),
+        (r"try {} catch(e) {}", r"try {} catch{}"),
+        (r"try {} catch (e){}", r"try {} catch {}"),
+        (r"try {} catch ({}) {}", r"try {} catch {}"),
+        (r"try {} catch ({message}) {}", r"try {} catch {}"),
+        (r"try {} catch ({message: notUsedMessage}) {}", r"try {} catch {}"),
+        (r"try {} catch ({cause: {message}}) {}", r"try {} catch {}"),
+    ];
+
+    Tester::new(PreferOptionalCatchBinding::NAME, pass, fail).expect_fix(fix).test_and_snapshot();
 }

crates/oxc_linter/src/snapshots/prefer_optional_catch_binding.snap

@@ -1,57 +1,67 @@
 ---
 source: crates/oxc_linter/src/tester.rs
+assertion_line: 234
 ---
   ⚠ eslint-plugin-unicorn(prefer-optional-catch-binding): Prefer omitting the catch binding parameter if it is unused
    ╭─[prefer_optional_catch_binding.tsx:1:15]
  1 │ try {} catch (_) {}
    ·               ─
    ╰────
+  help: Delete this code.
 
   ⚠ eslint-plugin-unicorn(prefer-optional-catch-binding): Prefer omitting the catch binding parameter if it is unused
    ╭─[prefer_optional_catch_binding.tsx:1:15]
  1 │ try {} catch (theRealErrorName) {}
    ·               ────────────────
    ╰────
+  help: Delete this code.
 
   ⚠ eslint-plugin-unicorn(prefer-optional-catch-binding): Prefer omitting the catch binding parameter if it is unused
    ╭─[prefer_optional_catch_binding.tsx:1:25]
  1 │ try    {    } catch    (e)
    ·                         ─
  2 │                   {    }
    ╰────
+  help: Delete this code.
 
   ⚠ eslint-plugin-unicorn(prefer-optional-catch-binding): Prefer omitting the catch binding parameter if it is unused
    ╭─[prefer_optional_catch_binding.tsx:1:14]
  1 │ try {} catch(e) {}
    ·              ─
    ╰────
+  help: Delete this code.
 
   ⚠ eslint-plugin-unicorn(prefer-optional-catch-binding): Prefer omitting the catch binding parameter if it is unused
    ╭─[prefer_optional_catch_binding.tsx:1:15]
  1 │ try {} catch (e){}
    ·               ─
    ╰────
+  help: Delete this code.
 
   ⚠ eslint-plugin-unicorn(prefer-optional-catch-binding): Prefer omitting the catch binding parameter if it is unused
    ╭─[prefer_optional_catch_binding.tsx:1:15]
  1 │ try {} catch ({}) {}
    ·               ──
    ╰────
+  help: Delete this code.
 
   ⚠ eslint-plugin-unicorn(prefer-optional-catch-binding): Prefer omitting the catch binding parameter if it is unused
    ╭─[prefer_optional_catch_binding.tsx:1:15]
  1 │ try {} catch ({message}) {}
    ·               ─────────
    ╰────
+  help: Delete this code.
 
   ⚠ eslint-plugin-unicorn(prefer-optional-catch-binding): Prefer omitting the catch binding parameter if it is unused
    ╭─[prefer_optional_catch_binding.tsx:1:15]
  1 │ try {} catch ({message: notUsedMessage}) {}
    ·               ─────────────────────────
    ╰────
+  help: Delete this code.
 
   ⚠ eslint-plugin-unicorn(prefer-optional-catch-binding): Prefer omitting the catch binding parameter if it is unused
    ╭─[prefer_optional_catch_binding.tsx:1:15]
  1 │ try {} catch ({cause: {message}}) {}
    ·               ──────────────────
    ╰────
+  help: Delete this code.