Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(napi): expose module type info in ResolveResult #223

Merged

Conversation

Brooooooklyn
Copy link
Contributor

@Brooooooklyn Brooooooklyn commented Jul 11, 2024

See https://github.com/oxc-project/oxc-node/blob/main/src/lib.rs#L345-L358 for the context:

We need to know the module type for resolved paths, so we can pass it to the Node.js import loader hook.

This can also fix swc-project/swc-node#788

@Brooooooklyn Brooooooklyn requested a review from Boshen July 11, 2024 07:30
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Brooooooklyn and the rest of your teammates on Graphite Graphite

Copy link

codspeed-hq bot commented Jul 11, 2024

CodSpeed Performance Report

Merging #223 will not alter performance

Comparing 07-11-feat_napi_expose_module_type_info_in_resolveresult (95b605a) with main (5d4421a)

Summary

✅ 3 untouched benchmarks

Copy link

codecov bot commented Jul 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.95%. Comparing base (5d4421a) to head (95b605a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #223   +/-   ##
=======================================
  Coverage   96.95%   96.95%           
=======================================
  Files          11       11           
  Lines        2297     2297           
=======================================
  Hits         2227     2227           
  Misses         70       70           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Boshen Boshen merged commit e678d0b into main Jul 11, 2024
22 checks passed
@Boshen Boshen deleted the 07-11-feat_napi_expose_module_type_info_in_resolveresult branch July 11, 2024 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

need help building example, esmregister + esmock
3 participants