Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Russian translation #1123

Closed
Allineer opened this issue Nov 15, 2021 · 15 comments · Fixed by #1133
Closed

Russian translation #1123

Allineer opened this issue Nov 15, 2021 · 15 comments · Fixed by #1133
Assignees
Milestone

Comments

@Allineer
Copy link
Contributor

Allineer commented Nov 15, 2021

mutableContactDistanceUnit.postValue(if (distanceBetween[0] > 1000) "km" else "m")

android:summary="on GitHub"

<PreferenceCategory app:title="Feedback">

android:summary="File on GitHub"

android:title="Report an issue"

Can we translate this strings?


<string name="aboutTranslationsSummary">Currently available in %d languages!</string>

How about plurals for "languages"?


image

Can we move this block to the left a few pixels?
One character for the string contactDetailsDistance does not fit in the space allotted to it :(

@Allineer
Copy link
Contributor Author

@growse I have checked my translation on beta 3 and have a number of fixes. I will prepare a PR in the next few hours. Sorry :(

@growse
Copy link
Collaborator

growse commented Nov 15, 2021

No problem - we can do another release pretty easily, I just wanted to get a tag for v2.4.3 so I could actually work on getting it submitted to F-Droid.

Thanks!

@Allineer
Copy link
Contributor Author

@growse How about questions in the first message?

@growse
Copy link
Collaborator

growse commented Nov 15, 2021

Sorry, forgot to say.

Yes, all good points. I'll update extracting some of those as string resources shortly, and look at re-laying the contact bottom sheet to prevent truncation.

On the plurals, I didn't bother setting it to be a plural, because it's essentially never going to be singular.

@Allineer
Copy link
Contributor Author

Allineer commented Nov 15, 2021

Never say "never" :)

451 languages = 451 язык
452 languages = 452 языка
456 languages = 456 языков

@growse
Copy link
Collaborator

growse commented Nov 15, 2021

Touché :D

@growse growse added this to the v2.4.4 milestone Nov 19, 2021
@growse growse self-assigned this Nov 19, 2021
growse added a commit that referenced this issue Nov 24, 2021
Also converted `aboutTranslationsSummary` to a plural. Partial fix for #1123
@growse
Copy link
Collaborator

growse commented Nov 24, 2021

Resources updated. Looking at the bottom sheet layout now.

edit

Just re-read the android docs on plurals: https://developer.android.com/guide/topics/resources/string-resource#Plurals

From the looks of things, they only support varying the resource based on zero, one, two, few, many, and other. Not sure how that would support the 451/452/456 case you highlighted....

growse added a commit that referenced this issue Nov 24, 2021
Also converted `aboutTranslationsSummary` to a plural. Partial fix for #1123
@growse growse closed this as completed in 17cd3b8 Nov 24, 2021
@Allineer
Copy link
Contributor Author

Allineer commented Nov 29, 2021

@growse, can we translate this too?

mutableContactDistanceUnit.postValue(if (distanceBetween[0] > 1000) "km" else "m")

@growse
Copy link
Collaborator

growse commented Nov 29, 2021

I added contactDetailsDistanceUnitKilometres and contactDetailsDistanceUnitMeters

@Allineer
Copy link
Contributor Author

Allineer commented Dec 7, 2021

@growse, Andrew, we still have an issue from the first screenshot.

image

@growse
Copy link
Collaborator

growse commented Dec 7, 2021

Good spot. I thought the auto-sizing was working properly, but obviously not. Let me try and figure out.

@Allineer
Copy link
Contributor Author

Allineer commented Dec 9, 2021

Oh no :'(

2e8bbab

@growse , can you revert this commit for the Russian translation?

Or I need to update it on POEditor?

@growse
Copy link
Collaborator

growse commented Dec 10, 2021

Ah boo - I missed that. I'll try and revert the Russian translations and then get POEditor up to date.

growse added a commit that referenced this issue Dec 13, 2021
Fixes #1145

Also removes unused resources, and reverts overwrite of ru locale
changes as per #1123
@growse
Copy link
Collaborator

growse commented Dec 13, 2021

Ok, I've reverted those changes. @Allineer can you check the latest on master and let me know if it looks right, and then I'll pull those into POEditor?

@Allineer
Copy link
Contributor Author

@growse, I confirm. Everything is correct. Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants