Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: View share info while share reciever has been deleted resulted in share info not rendered at all #9355

Closed
wants to merge 2 commits into from
Closed

Fix: View share info while share reciever has been deleted resulted in share info not rendered at all #9355

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7b799a4
Fix
Jul 6, 2023
e35d322
Lint
Jul 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/web-app-files/src/store/actions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -390,7 +390,7 @@ export default {
return Promise.allSettled(shareQueriesPromises).then(() => {
context.commit(
'OUTGOING_SHARES_SET',
shares.filter((s) => s.outgoing)
shares.filter((s) => s.outgoing && s.collaborator.name !== undefined)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will break link shares because they don't have a collaborator prop. Their name sit's in s.name.

)
context.commit(
'INCOMING_SHARES_SET',
Expand Down