Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[full-ci] Update favorites on removal #9237

Merged

Conversation

pascalwengerter
Copy link
Contributor

Description

Continuation of #9078, I'll need to investigate CI failures but can't on the CERN fork

@ownclouders
Copy link
Contributor

ownclouders commented Jun 14, 2023

Results for acceptance oC10 https://drone.owncloud.com/owncloud/web/36559/71/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUIFavorites-unfavoriteFile_feature-L53.png

webUIFavorites-unfavoriteFile_feature-L53.png

@pascalwengerter pascalwengerter marked this pull request as ready for review June 15, 2023 00:08
@ownclouders
Copy link
Contributor

ownclouders commented Jun 15, 2023

Results for acceptance oCIS https://drone.owncloud.com/owncloud/web/36567/54/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUIFavorites-unfavoriteFile_feature-L101.png

webUIFavorites-unfavoriteFile_feature-L101.png

webUIFavorites-unfavoriteFile_feature-L70.png

webUIFavorites-unfavoriteFile_feature-L70.png

webUIFavorites-unfavoriteFile_feature-L86.png

webUIFavorites-unfavoriteFile_feature-L86.png

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

75.0% 75.0% Coverage
0.0% 0.0% Duplication

@pascalwengerter
Copy link
Contributor Author

CI is green, whoever reviews this please test it with oC10 (pro tip since the favorites page is broken in oCIS atm). And please squash-merge

Copy link
Contributor

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works like a charm 💪 thank you @elizavetaRa and @pascalwengerter

@kulmann kulmann merged commit 3d58150 into owncloud:master Jun 20, 2023
@tbsbdr tbsbdr mentioned this pull request Jun 26, 2023
37 tasks
@tbsbdr tbsbdr added this to the CERN Web Merge milestone Jul 10, 2023
@pascalwengerter pascalwengerter deleted the up_up_update_favorites_on_removal branch July 13, 2023 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants