Cloud import (first iteration: OneDrive) #9150
Conversation
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
| /** | ||
| * Asserts whether the modal should render a confirm button | ||
| */ | ||
| withoutButtonConfirm: { |
There was a problem hiding this comment.
needed because we have no confirmation button in the import modal
packages/web-runtime/src/composables/upload/uppyPlugins/customDashboard.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
FYI: This plugin is going to handle all Uppy file uploads in the future, therefore it's called HandleUpload. We will tackle this in a follow-up PR. For now, the plugin only prepares the files for the cloud import though.
| * @param file | ||
| */ | ||
| getRelativeFilePath = (file): string | undefined => { | ||
| const relativePath = file.webkitRelativePath || (file as any).relativePath |
There was a problem hiding this comment.
Totally agree! I'll tackle this in the follow up PR because it refactors the plugin by quite a lot.
| volumes: | ||
| uploads: | ||
| uppy_companion_datadir: | ||
| traefik_letsencrypt: |
There was a problem hiding this comment.
Hmm - with this vite and ocis/traefik don't share the same certs anymore, right?
|
It would be great to have documentation on how to add secrets to docker-compose |
I added a brief comment on how to do it in the PR description 👍 For the full docs I'd rather wait until we have the extension running to put it there. |
Co-authored-by: Dominik Schmidt <dev@dominik-schmidt.de> Co-authored-by: Paul Neubauer <paulneubauer@live.de>
|
SonarCloud Quality Gate failed. |
Description
Implements an action to import files from other clouds. The first iteration supports
OneDrive. Needs owncloud/ocis#6453 for the config part.You need to run the
ocistraefikandcompanioncontainers. Companion runs athttps://host.docker.internal:9200/companionwhich needs to be defined as companion URL in oCIS (or hard-coded in theConfigurationManagerfor now).Please contact me for secret keys if you want to test it yourself. Those need to be added as env variables of the
companioncontainer:Screenshots
Related Issue
Types of changes
To-Do
Follow-up