Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[full-ci][tests-only]Skip scenario related to occ command in ocis #7767

Merged
merged 1 commit into from
Nov 1, 2022
Merged

[full-ci][tests-only]Skip scenario related to occ command in ocis #7767

merged 1 commit into from
Nov 1, 2022

Conversation

amrita-shrestha
Copy link
Contributor

@amrita-shrestha amrita-shrestha commented Oct 11, 2022 •
edited
Loading

Description

This PR skips tests related to the issue owncloud/ocis#1328 for OCIS as these will be implemented for spaces but not like they are implemented in OC10 now.

Related Issue

Motivation and Context

How Has This Been Tested?

  • locally
  • CI

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@amrita-shrestha amrita-shrestha self-assigned this Oct 11, 2022
@amrita-shrestha amrita-shrestha force-pushed the removeClosedIssueOccCoomandFromExpectedFailure branch from 05dd6d7 to e54594f Compare October 11, 2022 10:49
@amrita-shrestha amrita-shrestha marked this pull request as ready for review October 12, 2022 04:36
@amrita-shrestha amrita-shrestha force-pushed the removeClosedIssueOccCoomandFromExpectedFailure branch from e54594f to e0ebad1 Compare October 12, 2022 04:41
@amrita-shrestha amrita-shrestha requested review from SagarGi, SwikritiT, saw-jan and grgprarup and removed request for SagarGi October 12, 2022 04:42
@amrita-shrestha amrita-shrestha force-pushed the removeClosedIssueOccCoomandFromExpectedFailure branch from e0ebad1 to 8a517b6 Compare October 12, 2022 07:46
amrita-shrestha
amrita-shrestha commented Oct 12, 2022
View reviewed changes
tests/acceptance/features/webUIRestrictSharing/restrictReSharing.feature Outdated Show resolved Hide resolved
tests/acceptance/features/webUIRestrictSharing/restrictSharing.feature Outdated Show resolved Hide resolved
tests/acceptance/features/webUIRestrictSharing/restrictSharing.feature Outdated Show resolved Hide resolved
tests/acceptance/features/webUIRestrictSharing/restrictSharing.feature Outdated Show resolved Hide resolved
tests/acceptance/features/webUISharingAcceptShares/acceptShares.feature Outdated Show resolved Hide resolved
tests/acceptance/features/webUISharingInternalGroups/shareWithGroups.feature Outdated Show resolved Hide resolved
tests/acceptance/features/webUISharingInternalUsersBlacklisted/shareWithUsers.feature Outdated Show resolved Hide resolved
@ownclouders
Copy link
Contributor

ownclouders commented Oct 12, 2022 •
edited
Loading

Results for oCISSharingInternal1 https://drone.owncloud.com/owncloud/web/29495/61/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUISharingInternalGroups-shareWithGroups_feature-L254.png

webUISharingInternalGroups-shareWithGroups_feature-L254.png

webUISharingInternalGroups-shareWithGroups_feature-L276.png

webUISharingInternalGroups-shareWithGroups_feature-L276.png

webUISharingInternalGroups-shareWithGroups_feature-L306.png

webUISharingInternalGroups-shareWithGroups_feature-L306.png

webUISharingInternalGroups-shareWithGroups_feature-L307.png

webUISharingInternalGroups-shareWithGroups_feature-L307.png

webUISharingInternalGroups-shareWithGroups_feature-L77.png

webUISharingInternalGroups-shareWithGroups_feature-L77.png

@amrita-shrestha amrita-shrestha force-pushed the removeClosedIssueOccCoomandFromExpectedFailure branch from 8a517b6 to 9036ae4 Compare October 12, 2022 09:32
@amrita-shrestha amrita-shrestha force-pushed the removeClosedIssueOccCoomandFromExpectedFailure branch from 9036ae4 to ceaf345 Compare October 17, 2022 06:15
SwikritiT
SwikritiT reviewed Oct 17, 2022
View reviewed changes
Copy link
Contributor

@SwikritiT SwikritiT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

grgprarup
grgprarup reviewed Oct 17, 2022
View reviewed changes
Copy link
Contributor

@grgprarup grgprarup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

SagarGi
SagarGi reviewed Oct 17, 2022
View reviewed changes
Copy link
Member

@SagarGi SagarGi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

saw-jan
saw-jan reviewed Oct 18, 2022
View reviewed changes
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some indentation

tests/acceptance/features/webUIRestrictSharing/restrictSharing.feature Outdated Show resolved Hide resolved
tests/acceptance/features/webUIRestrictSharing/restrictSharing.feature Outdated Show resolved Hide resolved
tests/acceptance/features/webUIRestrictSharing/restrictSharing.feature Outdated Show resolved Hide resolved
tests/acceptance/features/webUIRestrictSharing/restrictSharing.feature Outdated Show resolved Hide resolved
tests/acceptance/features/webUISharingInternalGroups/shareWithGroups.feature Outdated Show resolved Hide resolved
@amrita-shrestha amrita-shrestha force-pushed the removeClosedIssueOccCoomandFromExpectedFailure branch 2 times, most recently from daa7b0b to 3d83287 Compare October 19, 2022 07:13
saw-jan
saw-jan reviewed Oct 19, 2022
View reviewed changes
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@grgprarup grgprarup requested a review from phil-davis October 19, 2022 10:18
@amrita-shrestha amrita-shrestha force-pushed the removeClosedIssueOccCoomandFromExpectedFailure branch 2 times, most recently from eb35a97 to 425ab54 Compare October 31, 2022 09:06
@amrita-shrestha amrita-shrestha force-pushed the removeClosedIssueOccCoomandFromExpectedFailure branch from 425ab54 to f63a688 Compare October 31, 2022 10:17
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 1, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@amrita-shrestha amrita-shrestha merged commit 8616778 into master Nov 1, 2022
@delete-merged-branch delete-merged-branch bot deleted the removeClosedIssueOccCoomandFromExpectedFailure branch November 1, 2022 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grgprarup grgprarup grgprarup left review comments

@SwikritiT SwikritiT SwikritiT left review comments

@SagarGi SagarGi SagarGi left review comments

@saw-jan saw-jan saw-jan left review comments

@individual-it individual-it individual-it approved these changes

@kiranparajuli589 kiranparajuli589 Awaiting requested review from kiranparajuli589

Assignees

@amrita-shrestha amrita-shrestha

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@amrita-shrestha @ownclouders @individual-it @grgprarup @kiranparajuli589 @SwikritiT @SagarGi @saw-jan