Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docker-compose dev env for latest ocis #7054

Merged
merged 1 commit into from
May 24, 2022

Conversation

dschmidt
Copy link
Member

Description

This sets all missing environment variables in our docker-compose.yml to make latest ocis launch again.

The ocis config path that was checked in our custom entrypoint is obsolete, it should be /etc/ocis/ocis.yml instead.
But even when the path is fixed:
when the file exists, but our environment variables are incomplete, ocis tells us to run ocis init, which then fails because the file already exists.

@dragonchaser suggested we might setup a drone cron pipeline that syncs the env variables set here https://github.com/owncloud/ocis/blob/master/.vscode/launch.json to our docker-compose.yml file or to a .env file.

Related Issue

  • Fixes <issue_link>

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@update-docs
Copy link

update-docs bot commented May 24, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With these changes you can get rid of the entrypoint file entirely.

@kulmann kulmann merged commit 7984af8 into master May 24, 2022
@delete-merged-branch delete-merged-branch bot deleted the fix_ocis_docker_compose_service branch May 24, 2022 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants