-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tests-only][full-ci]Update expected to fail file #7033
Conversation
Results for oCISSharingBasic https://drone.owncloud.com/owncloud/web/25820/54/1 |
539cbd7
to
5d8ea8d
Compare
@@ -1,25 +0,0 @@ | |||
@app-required @notifications-app-required @ocis-reva-issue-14 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to this comment #5227 (comment), there won't be a link in the notification so this test doesn't seem relevant anymore
@@ -1,24 +0,0 @@ | |||
@app-required @notifications-app-required @notToImplementOnOCIS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to this comment #5227 (comment), there won't be a link in the notification so this test doesn't seem relevant anymore
4ae546b
to
e022bab
Compare
@@ -141,7 +141,7 @@ Feature: Resharing shared files with different permissions | |||
And the user opens folder "Shares" using the webUI | |||
Then the user should not be able to share resource "lorem.txt" using the webUI | |||
|
|||
@issue-5461 | |||
@skipOnOCIS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test is skipped because as mentioned in the issue #6896, it also has a similar workflow of opening the Shares
folder through UI and doing some action. Previously this test was expected to fail but they were linked to a closed issue.
@@ -162,7 +162,7 @@ Feature: Resharing shared files with different permissions | |||
| item_type | folder | | |||
| permissions | share, delete, read | | |||
|
|||
@issue-5461 | |||
@skipOnOCIS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test is skipped because as mentioned in the issue #6896, it also has a similar workflow of opening the Shares folder through UI and doing some action. Previously this test was expected to fail but they were linked to a closed issue.
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm 👍
And as "Brian" folder "from_Alice" should exist inside folder "/Shares/simple-folder" in the server | ||
And as "Brian" folder "from_Carol" should exist inside folder "/Shares/simple-folder" in the server |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: this seems like strange behavior, but if that is the way that oCIS should work then that is what we test.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
Open tasks: