Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only][full-ci]Update expected to fail file #7033

Merged
merged 1 commit into from
May 25, 2022

Conversation

SwikritiT
Copy link
Contributor

@SwikritiT SwikritiT commented May 23, 2022

Description

Related Issue

Motivation and Context

How Has This Been Tested?

  • locally
  • CI

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@SwikritiT SwikritiT self-assigned this May 23, 2022
@ownclouders
Copy link
Contributor

ownclouders commented May 23, 2022

Results for oCISSharingBasic https://drone.owncloud.com/owncloud/web/25820/54/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUISharingAcceptShares-acceptShares_feature-L228.png

webUISharingAcceptShares-acceptShares_feature-L228.png

@SwikritiT SwikritiT changed the title [tests-only]Update expected to fail file [tests-only][full-ci]Update expected to fail file May 23, 2022
@SwikritiT SwikritiT force-pushed the update-expected-to-fail-file branch 2 times, most recently from 539cbd7 to 5d8ea8d Compare May 24, 2022 04:28
@@ -1,25 +0,0 @@
@app-required @notifications-app-required @ocis-reva-issue-14
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to this comment #5227 (comment), there won't be a link in the notification so this test doesn't seem relevant anymore

@@ -1,24 +0,0 @@
@app-required @notifications-app-required @notToImplementOnOCIS
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to this comment #5227 (comment), there won't be a link in the notification so this test doesn't seem relevant anymore

@SwikritiT SwikritiT force-pushed the update-expected-to-fail-file branch from 4ae546b to e022bab Compare May 24, 2022 10:40
@@ -141,7 +141,7 @@ Feature: Resharing shared files with different permissions
And the user opens folder "Shares" using the webUI
Then the user should not be able to share resource "lorem.txt" using the webUI

@issue-5461
@skipOnOCIS
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test is skipped because as mentioned in the issue #6896, it also has a similar workflow of opening the Shares folder through UI and doing some action. Previously this test was expected to fail but they were linked to a closed issue.

@@ -162,7 +162,7 @@ Feature: Resharing shared files with different permissions
| item_type | folder |
| permissions | share, delete, read |

@issue-5461
@skipOnOCIS
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test is skipped because as mentioned in the issue #6896, it also has a similar workflow of opening the Shares folder through UI and doing some action. Previously this test was expected to fail but they were linked to a closed issue.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@SwikritiT SwikritiT marked this pull request as ready for review May 24, 2022 11:18
Copy link
Contributor

@kiranparajuli589 kiranparajuli589 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

Comment on lines +258 to +259
And as "Brian" folder "from_Alice" should exist inside folder "/Shares/simple-folder" in the server
And as "Brian" folder "from_Carol" should exist inside folder "/Shares/simple-folder" in the server
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: this seems like strange behavior, but if that is the way that oCIS should work then that is what we test.

@phil-davis phil-davis merged commit 57120a0 into master May 25, 2022
@delete-merged-branch delete-merged-branch bot deleted the update-expected-to-fail-file branch May 25, 2022 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants