Add set password modal

[AlexAndBear]

Description

Related Issue

• Fixes OC10 public links: Show Password-promt if passwords are enforced #6963

Motivation and Context

How Has This Been Tested?

• test environment:
• test case 1:
• test case 2:
• ...

Screenshots (if appropriate):

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Technical debt
• Tests

Checklist:

• Code changes
• Unit tests added
• Acceptance tests added
• Documentation ticket raised:

Open tasks:

• ...

[update-docs]

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

[sonarqubecloud]

SonarCloud Quality Gate failed.   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
2 Code Smells

0.0% Coverage
0.0% Duplication

[pascalwengerter]

The same check would have to happen in FileLinks.vue both for creating and updating links 😬

[AlexAndBear]

@pascalwengerter
is this a statement or a guess?

AFAIK we have this check on creating links ?

Just on edit it's not perfect yet

[pascalwengerter]

@pascalwengerter is this a statement or a guess?

AFAIK we have this check on creating links ?

Just on edit it's not perfect yet

Statement 😋 the form you refer to will be removed in #6961 with a similar logic as in creating quickLinks, so create/update links in the FileLinks.vue need the password-modal if a password is enforced for the target role

[AlexAndBear]

@pascalwengerter ok, but I think the issue ticket is not targeting this, will be done in the future, you might want to ping me after merge

[pascalwengerter]

@pascalwengerter ok, but I think the issue ticket is not targeting this, will be done in the future, you might want to ping me after merge

Tobi's ticket is targeting this (or more like "what we spoke about in a call yesterday and which isn't clear in the ticket, namely update failures when changing roles via the dropdowns for links that would require a password for the new role"), your PR closes what is reported in #6782. I'm fine with merging this PR, but we'd have to reopen #6963 again after merge with an updated description

[pascalwengerter]

I'm fine with merging now as code LGTM, we'll have to put more work into password-enforcement upon creating/updating links in the sidebar in the future though. Also, please squash-on-merge :)

[AlexAndBear]

@pascalwengerter can we please open a new issue with detailed information?

[pascalwengerter]

@pascalwengerter can we please open a new issue with detailed information?

Taking care of it now, thx

[pascalwengerter]

@pascalwengerter can we please open a new issue with detailed information?

Taking care of it now, thx

Lives in #6974 now