Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup FileLinks component unit test run warnings #6862

Merged
merged 1 commit into from
May 5, 2022

Conversation

kiranparajuli589
Copy link
Contributor

Description

Cleanup FileLinks component unit test run warnings

Related Issue

Motivation and Context

How Has This Been Tested?

  • 🤖

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@kiranparajuli589 kiranparajuli589 force-pushed the fix-file-links-unit-tests-console-warns branch from 2f3c23a to b76e76d Compare May 4, 2022 10:38
@kiranparajuli589
Copy link
Contributor Author

unit test run is now again nice and tidy https://drone.owncloud.com/owncloud/web/25265/10/7

@ownclouders
Copy link
Contributor

ownclouders commented May 4, 2022

Results for oCISSharingInternal1 https://drone.owncloud.com/owncloud/web/25318/60/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUISharingInternalGroups-shareWithGroups_feature-L100.png

webUISharingInternalGroups-shareWithGroups_feature-L100.png

webUISharingInternalGroups-shareWithGroups_feature-L138.png

webUISharingInternalGroups-shareWithGroups_feature-L138.png

webUISharingInternalGroups-shareWithGroups_feature-L19.png

webUISharingInternalGroups-shareWithGroups_feature-L19.png

webUISharingInternalGroups-shareWithGroups_feature-L244.png

webUISharingInternalGroups-shareWithGroups_feature-L244.png

webUISharingInternalGroupsEdgeCases-shareWithGroupsEdgeCases_feature-L42.png

webUISharingInternalGroupsEdgeCases-shareWithGroupsEdgeCases_feature-L42.png

webUISharingInternalGroupsEdgeCases-shareWithGroupsEdgeCases_feature-L45.png

webUISharingInternalGroupsEdgeCases-shareWithGroupsEdgeCases_feature-L45.png

webUISharingInternalGroupsEdgeCases-shareWithGroupsEdgeCases_feature-L63.png

webUISharingInternalGroupsEdgeCases-shareWithGroupsEdgeCases_feature-L63.png

webUISharingInternalGroupsEdgeCases-shareWithGroupsEdgeCases_feature-L81.png

webUISharingInternalGroupsEdgeCases-shareWithGroupsEdgeCases_feature-L81.png

webUISharingInternalGroupsEdgeCases-shareWithGroupsEdgeCases_feature-L99.png

webUISharingInternalGroupsEdgeCases-shareWithGroupsEdgeCases_feature-L99.png

💥 The acceptance tests pipeline failed. The build has been cancelled.

@kiranparajuli589 kiranparajuli589 force-pushed the fix-file-links-unit-tests-console-warns branch 2 times, most recently from fa060be to d2ace1a Compare May 5, 2022 03:14
Signed-off-by: Kiran Parajuli <kiranparajuli589@gmail.com>
@kiranparajuli589 kiranparajuli589 force-pushed the fix-file-links-unit-tests-console-warns branch from d2ace1a to ced6817 Compare May 5, 2022 08:16
@sonarqubecloud
Copy link

sonarqubecloud bot commented May 5, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@individual-it individual-it merged commit 7ad7956 into master May 5, 2022
@delete-merged-branch delete-merged-branch bot deleted the fix-file-links-unit-tests-console-warns branch May 5, 2022 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lots of warnings & errors when running unit tests
4 participants