[full-ci] Unify people&link shares into one sidebar panel #6701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
pascalwengerter
force-pushed
the
unify-sidebar-shares
branch
3 times, most recently
from
65524bd to
b180321
Compare
pascalwengerter
changed the title
pascalwengerter
force-pushed
the
unify-sidebar-shares
branch
from
b180321 to
653923a
Compare
|
Results for oCISSharingInternal2 https://drone.owncloud.com/owncloud/web/24421/60/1 💥 The acceptance tests failed on retry. Please find the screenshots inside ...
webUISharingInternalUsers-shareWithUsers_feature-L342.png |
pascalwengerter
force-pushed
the
unify-sidebar-shares
branch
from
653923a to
9a31e47
Compare
8 tasks
pascalwengerter
force-pushed
the
unify-sidebar-shares
branch
2 times, most recently
from
243f911 to
d8c584e
Compare
…ack-btn text to tooltip
Fix favorite&privateLink acceptance tests Bump ts-async-decorators from 0.1.2 to 0.3.0 Bumps [ts-async-decorators](https://github.com/dokmic/ts-async-decorators) from 0.1.2 to 0.3.0. - [Release notes](https://github.com/dokmic/ts-async-decorators/releases) - [Commits](dokmic/ts-async-decorators@0.1.2...0.3.0) --- updated-dependencies: - dependency-name: ts-async-decorators dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Dedupe deps && add changelog item
kulmann
suggested changes
Apr 5, 2022
| @@ -29,13 +29,13 @@ | |||
| > | |||
| <oc-button | |||
| v-if="!panel.default" | |||
| v-oc-tooltip="accessibleLabelBack" | |||
There was a problem hiding this comment.
What's the reason for this change? While I agree content wise (parent panel is the same all the time anyway) it reduces the clickable area by a lot.
There was a problem hiding this comment.
Sorry just saw this now. I updated it according to the design mockups 😬
|
Could you fix the code smells that sonarcloud complains about? |
|
SonarCloud Quality Gate failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
There's more work to do before the linked ticket can be closed, however this PR reorganizes the components file/folder structure and makes working in parallel with little conflicts possible