-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shared with column for incoming shares #6699
Conversation
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
Kudos, SonarCloud Quality Gate passed! |
Results for e2e-tests oC10 https://drone.owncloud.com/owncloud/web/24287/10/1 💥 To see the trace, please open the link in the console ...
npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/24287/tracing/alice-can-share-this-weeks-meal-plan-with-all-parents-alice-2022-3-31-12-46-09.zipnpx playwright show-trace https://cache.owncloud.com/public/owncloud/web/24287/tracing/alice-can-share-this-weeks-meal-plan-with-all-parents-brian-2022-3-31-12-46-33.zipnpx playwright show-trace https://cache.owncloud.com/public/owncloud/web/24287/tracing/file-alice-2022-3-31-12-44-22.zipnpx playwright show-trace https://cache.owncloud.com/public/owncloud/web/24287/tracing/file-brian-2022-3-31-12-44-32.zipnpx playwright show-trace https://cache.owncloud.com/public/owncloud/web/24287/tracing/folder-alice-2022-3-31-12-42-49.zipnpx playwright show-trace https://cache.owncloud.com/public/owncloud/web/24287/tracing/folder-brian-2022-3-31-12-42-59.zip |
This is something many of our users (us, included) asked. I guess the fact that we show "shared with" for shares shared directly to the user is debatable, so we can change this if you prefer. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please move the sharedWith
field definition in ResourceTable.vue
to after the shareOwner
field definition? It looks weird that sharedWith
is basically the first field after the share name. If you could add an enhancement
changelog item on top I'd be fine with the PR. We can iterate further about the user vs group share issue in subsequent PRs.
fdf76b6
to
712db99
Compare
712db99
to
270cb33
Compare
Superseded by #6717 - thanks for your contribution! |
Description
Added "Shared with" column for incoming shares
Related Issue
Motivation and Context
Incoming shares can also have a group as sharee, the information about it can be relevant information for the user.
Types of changes
Checklist:
Open tasks: