Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shared with column for incoming shares #6699

Closed
wants to merge 5 commits into from

Conversation

elizavetaRa
Copy link
Member

Description

Added "Shared with" column for incoming shares

Related Issue

Motivation and Context

Incoming shares can also have a group as sharee, the information about it can be relevant information for the user.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

@update-docs
Copy link

update-docs bot commented Mar 31, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@diocas
Copy link
Contributor

diocas commented Mar 31, 2022

This is something many of our users (us, included) asked.
You now support sharing spaces with groups, right? So this will be useful as well.

I guess the fact that we show "shared with" for shares shared directly to the user is debatable, so we can change this if you prefer.

Copy link
Contributor

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please move the sharedWith field definition in ResourceTable.vue to after the shareOwner field definition? It looks weird that sharedWith is basically the first field after the share name. If you could add an enhancement changelog item on top I'd be fine with the PR. We can iterate further about the user vs group share issue in subsequent PRs.

@elizavetaRa elizavetaRa force-pushed the upstream_shared-with branch from fdf76b6 to 712db99 Compare April 1, 2022 12:28
@elizavetaRa elizavetaRa force-pushed the upstream_shared-with branch from 712db99 to 270cb33 Compare April 1, 2022 12:31
@kulmann kulmann mentioned this pull request Apr 1, 2022
9 tasks
@kulmann
Copy link
Contributor

kulmann commented Apr 1, 2022

Superseded by #6717 - thanks for your contribution!

@kulmann kulmann closed this Apr 1, 2022
@elizavetaRa elizavetaRa deleted the upstream_shared-with branch May 31, 2023 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Column "Shared With" is not shown in the table
4 participants