Support archive downloads on oc10 backends aka archiver v1.0.0 #6697
Conversation
Moved archive download related code to the `archiverService` to keep it in one place and expose less api for the service. Unit tests have been changed to only use the public api of the service as well.
| @@ -127,7 +127,14 @@ export default { | |||
| userReady({ store }) { | |||
| archiverService.initialize( | |||
| store.getters.configuration.server || window.location.origin, | |||
| get(store, 'getters.capabilities.files.archivers', []) | |||
| get(store, 'getters.capabilities.files.archivers', [ | |||
There was a problem hiding this comment.
long term we should add the v1.0.0 capability to core / php based backend. Added it as a fallback for compatibility in the meantime.
There was a problem hiding this comment.
True. Care to open a ticket in github.com/owncloud/core/issues?:)
|
Results for oC10Files2 https://drone.owncloud.com/owncloud/web/24280/17/1 💥 The acceptance tests failed on retry. Please find the screenshots inside ...
webUIFilesActionMenu-fileFolderActionMenu_feature-L37.png |
|
SonarCloud Quality Gate failed. |
| @@ -127,7 +127,14 @@ export default { | |||
| userReady({ store }) { | |||
| archiverService.initialize( | |||
| store.getters.configuration.server || window.location.origin, | |||
| get(store, 'getters.capabilities.files.archivers', []) | |||
| get(store, 'getters.capabilities.files.archivers', [ | |||
There was a problem hiding this comment.
True. Care to open a ticket in github.com/owncloud/core/issues?:)
will followup in a separate PR in the future, but needs backend changes first. for the moment this already brings new functionality for the authenticated context. |
Description
Support archive downloads on oc10 backends aka archiver v1.0.0.
Also moved archive download related code to the
archiverServiceto keep itin one place and expose less api for the service.
Unit tests have been changed to only use the public api of the service
as well.
Related Issue
Motivation and Context
customer demand
How Has This Been Tested?
Types of changes
Checklist: