Add unlimited option to space quota #6693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 31, 2022 09:52
AlexAndBear
commented
Mar 31, 2022
AlexAndBear
commented
Mar 31, 2022
| @@ -63,8 +63,21 @@ export default { | |||
| data: function () { | |||
| return { | |||
| selectedOption: {}, | |||
| options: [], | |||
| DEFAULT_OPTIONS: [ | |||
There was a problem hiding this comment.
moved to computed, due the need of gettext
|
Kudos, SonarCloud Quality Gate passed! |
lookacat
approved these changes
Mar 31, 2022
|
|
||
| const newOption = { | ||
| displayValue: (this.space.spaceQuota.total * Math.pow(10, -9)) | ||
| .toFixed(2) |
There was a problem hiding this comment.
Would maybe extract this into a variable for better readability, but not a show stopper.
There was a problem hiding this comment.
const newOption = {
displayValue: (this.space.spaceQuota.total * Math.pow(10, -9))
.toFixed(2)
.toString()
.replace('.00', ''),
displayUnit: 'GB',
value: this.space.spaceQuota.total
}
vs
const displayValue = (this.space.spaceQuota.total * Math.pow(10, -9))
.toFixed(2)
.toString()
.replace('.00', '')
const newOption = {
displayValue,
displayUnit: 'GB',
value: this.space.spaceQuota.total
}
IHMO this is not more readable if you keep the code in mind, that is on the same level
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enhancement: Spaces quota unlimited option
Space quota can now be set to unlimited
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
Open tasks: