Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow full screen external apps (i.e presentation mode) #6688

Merged
merged 3 commits into from
Apr 1, 2022
Merged

Allow full screen external apps (i.e presentation mode) #6688

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9d8ba2d
Allow full screen external apps (i.e presentation mode)
diocas Mar 29, 2022
a2e0dcb
changelog
diocas Mar 29, 2022
16e9242
Update tests
diocas Apr 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions changelog/unreleased/enhancement-full-scree-apps
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
Enhancement: Full screen external apps

It allows, for example, presentation apps to enter full screen.

https://github.com/owncloud/web/pull/6688
8 changes: 7 additions & 1 deletion packages/web-app-external/src/App.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
:src="appUrl"
class="oc-width-1-1 oc-height-1-1"
:title="iFrameTitle"
allowfullscreen
/>
<div v-if="appUrl && method === 'POST' && formParameters" class="oc-height-1-1">
<form :action="appUrl" target="app-iframe" method="post">
Expand All @@ -21,7 +22,12 @@
<input :name="key" :value="item" type="hidden" />
</div>
</form>
<iframe name="app-iframe" class="oc-width-1-1 oc-height-1-1" :title="iFrameTitle" />
<iframe
name="app-iframe"
class="oc-width-1-1 oc-height-1-1"
:title="iFrameTitle"
allowfullscreen
/>
</div>
</main>
</template>
Expand Down
4 changes: 2 additions & 2 deletions packages/web-app-external/tests/unit/__snapshots__/app.spec.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
exports[`The app provider extension should be able to load an iFrame via get 1`] = `
<main class="oc-height-1-1">
<h1 class="oc-invisible-sr">"exampleApp" app page</h1>
<!----> <iframe src="https://example.test/d12ab86/loe009157-MzBw" title="&quot;exampleApp&quot; app content area" class="oc-width-1-1 oc-height-1-1"></iframe>
<!----> <iframe src="https://example.test/d12ab86/loe009157-MzBw" title="&quot;exampleApp&quot; app content area" allowfullscreen="allowfullscreen" class="oc-width-1-1 oc-height-1-1"></iframe>
<!---->
</main>
`;
Expand All @@ -17,7 +17,7 @@ exports[`The app provider extension should be able to load an iFrame via post 1`
<form action="https://example.test/d12ab86/loe009157-MzBw" target="app-iframe" method="post"><input type="submit" class="oc-hidden" value="[object Object]">
<div><input name="access_token" type="hidden" value="asdfsadfsadf"></div>
<div><input name="access_token_ttl" type="hidden" value="123456"></div>
</form> <iframe name="app-iframe" title="&quot;exampleApp&quot; app content area" class="oc-width-1-1 oc-height-1-1"></iframe>
</form> <iframe name="app-iframe" title="&quot;exampleApp&quot; app content area" allowfullscreen="allowfullscreen" class="oc-width-1-1 oc-height-1-1"></iframe>
</div>
</main>
`;
Expand Down