Refactor spaces context menus #6659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Results for oCISSharingPerm3 https://drone.owncloud.com/owncloud/web/24171/65/1 💥 The acceptance tests failed on retry. Please find the screenshots inside ...
webUISharingFolderAdvancedPermissionMultipleUsers-sharedFolderWithMultipleUsersAdvancedPermissions_feature-L65.png |
JammingBen
force-pushed
the
spaces-context-menus
branch
2 times, most recently
from
2d7173b to
8e8384a
Compare
JammingBen
force-pushed
the
spaces-context-menus
branch
from
8e8384a to
682ff45
Compare
pascalwengerter
approved these changes
Mar 28, 2022
packages/web-app-files/tests/unit/components/__snapshots__/ContextActionMenu.spec.js.snap
Show resolved
Hide resolved
packages/web-app-files/src/components/Spaces/SpaceContextActions.vue
Outdated
Show resolved
Hide resolved
packages/web-app-files/src/mixins/spaces/actions/showMembers.js
Outdated
Show resolved
Hide resolved
| name: 'show-members', | ||
| icon: 'group', | ||
| iconFillType: 'line', | ||
| label: () => this.$gettext('Members'), |
There was a problem hiding this comment.
Isn't it "Show space members"?
| </oc-list> | ||
| </template> | ||
| </div> | ||
| <context-action-menu :menu-sections="menuSections" :items="items" /> |
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Spaces context menus have been adjusted visibly to match the other available context menus.
Also, the corresponding component has been abstracted in the course of this. This cleans up a lot of (duplicated) code across the spaces views and makes future adjustments easier.
Related Issue
Screenshots (if appropriate):
Types of changes
Checklist: