Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[full-ci] Use resharing capability instead of hardcoding isOcis #6619

Merged
merged 12 commits into from
Mar 18, 2022
Merged

[full-ci] Use resharing capability instead of hardcoding isOcis #6619

merged 12 commits into from
Mar 18, 2022

Conversation

dschmidt
Copy link
Member

Description

This PR replaces the not-so-granular isOcis getter (which relies on edition === 'reva') by composables which in turn read capabilities from the store.

Related Issue

Motivation and Context

The edition === 'reva' check blocks owncloud/ocis#2918

How Has This Been Tested?

  • Tests for the new composable(s) are added
  • Existing tests have been fixed

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • Find a smarter check than the resharing capability for deciding whether the account editing should be enabled or not

@update-docs
Copy link

update-docs bot commented Mar 17, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@dschmidt dschmidt force-pushed the resharing_capability branch from 62b949f to 53d410e Compare March 17, 2022 21:00
@ownclouders
Copy link
Contributor

Results for oCISTrashbinUploadMoveJourney https://drone.owncloud.com/owncloud/web/23848/69/1
The following scenarios passed on retry:

  • webUITrashbinRestore/trashbinRestore.feature:279

@ownclouders
Copy link
Contributor

Results for oCISSharingPublic1 https://drone.owncloud.com/owncloud/web/23848/67/1
The following scenarios passed on retry:

  • webUISharingPublicBasic/publicLinkCreate.feature:190

@fschade fschade mentioned this pull request Mar 18, 2022
Closed
25 tasks
@kulmann
Copy link
Contributor

kulmann commented Mar 18, 2022

can you please rebase? there are conflicts now. and #6577 has been merged with additional isOcis mocks in tests

@dschmidt dschmidt force-pushed the resharing_capability branch from 53d410e to 7161e33 Compare March 18, 2022 14:18
@dschmidt dschmidt force-pushed the resharing_capability branch from 7161e33 to 4727611 Compare March 18, 2022 14:28
@ownclouders
Copy link
Contributor

ownclouders commented Mar 18, 2022 •
edited
Loading

Results for oCISBasic https://drone.owncloud.com/owncloud/web/23894/51/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUIAccount-accountInformation_feature-L10.png

webUIAccount-accountInformation_feature-L10.png

@dschmidt dschmidt force-pushed the resharing_capability branch from 21c63f8 to dc07cc7 Compare March 18, 2022 19:18
@dschmidt dschmidt force-pushed the resharing_capability branch from dc07cc7 to 403a128 Compare March 18, 2022 19:25
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

79.5% 79.5% Coverage
7.3% 7.3% Duplication

kulmann
kulmann approved these changes Mar 18, 2022
View reviewed changes
Copy link
Contributor

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍🏻

@kulmann kulmann merged commit 35fbae0 into master Mar 18, 2022
@delete-merged-branch delete-merged-branch bot deleted the resharing_capability branch March 18, 2022 20:58
@kulmann kulmann mentioned this pull request Mar 21, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulmann kulmann kulmann approved these changes

@pascalwengerter pascalwengerter Awaiting requested review from pascalwengerter

@fschade fschade Awaiting requested review from fschade

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dschmidt @ownclouders @kulmann