WIP PDF Viewer #6575
WIP PDF Viewer #6575
Conversation
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
|
Results for oC10Files2 https://drone.owncloud.com/owncloud/web/23529/17/1 💥 The acceptance tests failed on retry. Please find the screenshots inside ...
webUIFilesActionMenu-fileFolderActionMenu_feature-L14.png |
| extensions: [ | ||
| { | ||
| extension: 'pdf', | ||
| newTab: true, |
There was a problem hiding this comment.
IMO it's not needed anymore to open in a new tab whenever the top bar is visible (which is always the case now). Also, the closeApp helper offers a way back to the source file in the files app with just one line of code.
There was a problem hiding this comment.
I don't think we will agree with this. We also consider opening in a new tab to be more consistent with other apps. Can I make it configurable? (the last time I looked at it, I think it would require some changes to pass the config here, but this would be an interesting thing to do for other apps as well).
| this.filePath = this.currentFileContext.path | ||
|
|
||
| try { | ||
| let resource = await this.getFileInfo( |
There was a problem hiding this comment.
Can be simplified by using getFileContents which you made available via useAppDefaults, right?
There was a problem hiding this comment.
The problem is that getFileContents returns text instead of blob.
There was a problem hiding this comment.
Then let's add handling of blob as resolveType here
This kind of logic should never be handled in an app imho
There was a problem hiding this comment.
@diocas Would you like me to take this over and adjust to that? (also some routing changes in my pipeline once again)
There was a problem hiding this comment.
Available by bumping the owncloud-sdk to v3.0.0-alpha.3
There was a problem hiding this comment.
@pascalwengerter feel free to take it, thanks (just add the cern tag to the new PR please)
|
Kudos, SonarCloud Quality Gate passed!
|
|
Results for oC10Files2 https://drone.owncloud.com/owncloud/web/23812/17/1 💥 The acceptance tests failed on retry. Please find the screenshots inside ...
webUIFilesActionMenu-fileFolderActionMenu_feature-L14.png |
To kickstart discussion.
This also doesn't fix the issue with the name missing when downloading, unfortunately.
#6167