Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show space members in the share panel for regular files inside a space #6554

Merged
merged 7 commits into from
Mar 18, 2022
Merged

Show space members in the share panel for regular files inside a space #6554

merged 7 commits into from
Mar 18, 2022

Conversation

JammingBen
Copy link
Contributor

@JammingBen JammingBen commented Mar 9, 2022 •
edited
Loading

Description

The space managers are now displayed in the sidebar for resources within a space. Also, space members are now sorted via role (managers first) and name.

Related Issue

Screenshots:

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@JammingBen JammingBen self-assigned this Mar 9, 2022
@owncloud owncloud deleted a comment from update-docs bot Mar 9, 2022
@JammingBen JammingBen force-pushed the spaces-members-share-panel branch 2 times, most recently from 04a8e93 to 6902c52 Compare March 9, 2022 11:54
@JammingBen JammingBen marked this pull request as ready for review March 9, 2022 11:55
@ownclouders
Copy link
Contributor

Results for oCISSharingAndUpload https://drone.owncloud.com/owncloud/web/23439/66/1
The following scenarios passed on retry:

  • webUIUpload/upload.feature:94

@ownclouders
Copy link
Contributor

Results for oCISSharingPublic1 https://drone.owncloud.com/owncloud/web/23439/67/1
The following scenarios passed on retry:

  • webUISharingPublicBasic/publicLinkCreate.feature:190

@JammingBen JammingBen requested a review from kulmann March 10, 2022 08:56
@JammingBen JammingBen force-pushed the spaces-members-share-panel branch from d27b37d to 21f9097 Compare March 11, 2022 08:44
@ownclouders
Copy link
Contributor

Results for oCISTrashbinUploadMoveJourney https://drone.owncloud.com/owncloud/web/23555/69/1
The following scenarios passed on retry:

  • webUITrashbinRestore/trashbinRestore.feature:279

@ownclouders
Copy link
Contributor

Results for oCISSharingAndUpload https://drone.owncloud.com/owncloud/web/23555/66/1
The following scenarios passed on retry:

  • webUIUpload/upload.feature:188

kulmann
kulmann suggested changes Mar 15, 2022
View reviewed changes
Copy link
Contributor

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, needs a rebase now. I merged #6602 and thus spaceId needs to be renamed to storageId.

@JammingBen JammingBen force-pushed the spaces-members-share-panel branch from 21f9097 to 0658a4d Compare March 16, 2022 07:34
@ownclouders
Copy link
Contributor

Results for e2e-tests oC10 https://drone.owncloud.com/owncloud/web/23728/10/1

💥 To see the trace, please open the link in the console ...

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/23728/tracing/alice-can-share-this-weeks-meal-plan-with-all-parents-alice-2022-3-16-07-46-30.zip

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/23728/tracing/alice-can-share-this-weeks-meal-plan-with-all-parents-brian-2022-3-16-07-46-47.zip

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/23728/tracing/alice-shares-folder-with-file-to-brian-alice-2022-3-16-07-48-34.zip

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/23728/tracing/alice-shares-folder-with-file-to-brian-brian-2022-3-16-07-48-41.zip

@ownclouders
Copy link
Contributor

Results for oCISSharingInternal2 https://drone.owncloud.com/owncloud/web/23733/60/1
💥 The acceptance tests pipeline failed. The build has been cancelled.

@ownclouders
Copy link
Contributor

Results for oCISSharingAutocompletion https://drone.owncloud.com/owncloud/web/23733/62/1
💥 The acceptance tests pipeline failed. The build has been cancelled.

@ownclouders
Copy link
Contributor

Results for oCISSharingPublic1 https://drone.owncloud.com/owncloud/web/23733/67/1
💥 The acceptance tests pipeline failed. The build has been cancelled.

@ownclouders
Copy link
Contributor

Results for oCISTrashbinUploadMoveJourney https://drone.owncloud.com/owncloud/web/23733/69/1
💥 The acceptance tests pipeline failed. The build has been cancelled.

@ownclouders
Copy link
Contributor

Results for oCISSharingPerm1 https://drone.owncloud.com/owncloud/web/23733/63/1
💥 The acceptance tests pipeline failed. The build has been cancelled.

@AlexAndBear AlexAndBear self-requested a review March 16, 2022 10:53
AlexAndBear
AlexAndBear approved these changes Mar 16, 2022
View reviewed changes
Copy link
Contributor

@AlexAndBear AlexAndBear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@ownclouders
Copy link
Contributor

Results for e2e-tests oC10 https://drone.owncloud.com/owncloud/web/23753/10/1

💥 To see the trace, please open the link in the console ...

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/23753/tracing/alice-shares-file-to-brian-alice-2022-3-16-11-07-59.zip

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/23753/tracing/alice-shares-folder-with-file-to-brian-alice-2022-3-16-11-09-18.zip

@JammingBen JammingBen force-pushed the spaces-members-share-panel branch from fe19c2c to 040ec37 Compare March 17, 2022 09:22
@JammingBen JammingBen force-pushed the spaces-members-share-panel branch from 040ec37 to 98efd4e Compare March 17, 2022 09:48
@JammingBen JammingBen added the Status:Needs-Review Needs review from a maintainer label Mar 17, 2022
@JammingBen JammingBen requested a review from kulmann March 17, 2022 10:14
@ownclouders
Copy link
Contributor

Results for oCISSharingInternal2 https://drone.owncloud.com/owncloud/web/23795/60/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUISharingInternalUsers-shareWithUsers_feature-L342.png

webUISharingInternalUsers-shareWithUsers_feature-L342.png

💥 The acceptance tests pipeline failed. The build has been cancelled.

@ownclouders
Copy link
Contributor

Results for e2e-tests oC10 https://drone.owncloud.com/owncloud/web/23800/10/1

💥 To see the trace, please open the link in the console ...

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/23800/tracing/folder-alice-2022-3-17-10-31-16.zip

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/23800/tracing/folder-brian-2022-3-17-10-31-24.zip

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

94.5% 94.5% Coverage
0.0% 0.0% Duplication

@ownclouders
Copy link
Contributor

Results for oC10IntegrationApp1 https://drone.owncloud.com/owncloud/web/23804/71/1
The following scenarios passed on retry:

  • webUIPrivateLinks/accessingPrivateLinks.feature:17

@fschade fschade mentioned this pull request Mar 18, 2022
Closed
25 tasks
kulmann
kulmann approved these changes Mar 18, 2022
View reviewed changes
Copy link
Contributor

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

packages/web-app-files/src/components/SideBar/Shares/FileShares.vue
@@ -43,6 +43,18 @@
</li>
</ul>
</template>
<template v-if="showSpaceMembers">
<h4 class="oc-text-initial oc-text-bold oc-my-s" v-text="spaceMemberLabel" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

top margin could be a bit more. but that can also happen in another PR

@kulmann kulmann merged commit 1009b5c into master Mar 18, 2022
@delete-merged-branch delete-merged-branch bot deleted the spaces-members-share-panel branch March 18, 2022 11:45
@JammingBen JammingBen removed the Status:Needs-Review Needs review from a maintainer label Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulmann kulmann kulmann approved these changes

@AlexAndBear AlexAndBear AlexAndBear approved these changes

@pascalwengerter pascalwengerter Awaiting requested review from pascalwengerter

@fschade fschade Awaiting requested review from fschade

Assignees

@JammingBen JammingBen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JammingBen @ownclouders @kulmann @AlexAndBear