Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dummy #6480

Closed
wants to merge 2 commits into from
Closed

Dummy #6480

Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions changelog/unreleased/bugfix-do-not-load-from-cache
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
Bugfix: Do not load files from cache

When apps (i.e Drawio) try to load a file, the browser caches the request.
If the file was modified somewhere else, this causes inconsistent results which prevent saving any changes until the cache is properly cleared.

https://github.com/owncloud/web/pull/6447
1 change: 1 addition & 0 deletions changelog/unreleased/enhancement-history-mode
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ Enhancement: Option to enable Vue history mode

We've added the option to use vue's history mode. All configuration is done automatically by the system.
To enable it, add a `<base href="PATH">` header tag to `index.html`, `oidc-callback.html` and `oidc-silent-redirect.html`.

Adding `<base>` is not needed for ocis.

https://github.com/owncloud/web/issues/6363
Expand Down
2 changes: 1 addition & 1 deletion packages/web-app-draw-io/src/App.vue
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ export default {
})
},
load() {
this.getFileContents(this.filePath, { resolveWithResponseObject: true })
this.getFileContents(this.filePath)
.then((resp) => {
this.currentETag = resp.headers.ETag
this.$refs.drawIoEditor.contentWindow.postMessage(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,8 @@ export function useAppFileHandling(options: AppFileHandlingOptions): AppFileHand
}
} else {
return client.files.getFileContents(filePath, {
resolveWithResponseObject: true
resolveWithResponseObject: true,
noCache: true
})
}
}
Expand Down