App compatibility for old named routes #6439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kulmann
force-pushed
the
router-view-name-catch
branch
from
6cb3bc2 to
6b2b428
Compare
|
Results for oCISSharingAndUpload https://drone.owncloud.com/owncloud/web/22789/66/1
|
|
Results for oCISSharingPublic1 https://drone.owncloud.com/owncloud/web/22789/67/1 💥 The acceptance tests failed on retry. Please find the screenshots inside ...
webUISharingPublicBasic-publicLinkCreate_feature-L190.png |
|
SonarCloud Quality Gate failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Apps had to define their route components for named views in the past, either
or
We've removed the named routes in #6401 so that routes now need to be defined as
component: ComponentNameThis broke "old" apps with an unrendered state, because the router-view with the respective name could not be found anymore.
This PR defines identical router-views for the
defaultname and for the oldappandfullscreennames, but all rendered in the same way (inside the app container, because we don't allow apps without topbar anymore).Also added a deprecation warning. We can basically revert this commit once we release the next major version.
Motivation and Context
App compatibility
How Has This Been Tested?
Manually define an app with the old schema and make sure that it renders correctly.
Types of changes
Checklist: