Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only] [full-ci] Bump oCIS commit id #6435

Merged
merged 3 commits into from
Feb 15, 2022
Merged

Conversation

phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Feb 15, 2022

Description

web 5.0 was just merged to master in PR #6424 - the oCIS commit id is quite up-to-date there, but there are a couple of other PRs merged in oCIS since that. So update the commit id here "to be sure".

Related Issue

owncloud/QA#721

How Has This Been Tested?

CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@ownclouders
Copy link
Contributor

Results for oCISTrashbinUploadMoveJourney https://drone.owncloud.com/owncloud/web/22759/69/1
The following scenarios passed on retry:

  • webUIUserJourney/journey1.feature:11

@ownclouders
Copy link
Contributor

Results for oCISFiles1 https://drone.owncloud.com/owncloud/web/22759/55/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUIDeleteFilesFolders-deleteFilesFolders_feature-L77.png

webUIDeleteFilesFolders-deleteFilesFolders_feature-L77.png

webUIDeleteFilesFolders-deleteFilesFolders_feature-L98.png

webUIDeleteFilesFolders-deleteFilesFolders_feature-L98.png

Copy link
Contributor

@pascalwengerter pascalwengerter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine if CI approves 🤖

@ownclouders
Copy link
Contributor

Results for oCISSharingAndUpload https://drone.owncloud.com/owncloud/web/22765/66/1
The following scenarios passed on retry:

  • webUIUpload/upload.feature:94

@ownclouders
Copy link
Contributor

Results for oCISFiles1 https://drone.owncloud.com/owncloud/web/22765/55/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUIDeleteFilesFolders-deleteFilesFolders_feature-L77.png

webUIDeleteFilesFolders-deleteFilesFolders_feature-L77.png

webUIDeleteFilesFolders-deleteFilesFolders_feature-L98.png

webUIDeleteFilesFolders-deleteFilesFolders_feature-L98.png

@ownclouders
Copy link
Contributor

Results for oCISSharingInternal2 https://drone.owncloud.com/owncloud/web/22765/60/1
The following scenarios passed on retry:

  • webUISharingInternalUsers/shareWithUsers.feature:342

@phil-davis
Copy link
Contributor Author

https://drone.owncloud.com/owncloud/web/22765/55/15

runsh: Total unexpected failed scenarios throughout the test run:
webUIDeleteFilesFolders/deleteFilesFolders.feature:77
webUIDeleteFilesFolders/deleteFilesFolders.feature:98

That is "unexpected" ;) - I need to investigate.

@kulmann
Copy link
Contributor

kulmann commented Feb 15, 2022

https://drone.owncloud.com/owncloud/web/22765/55/15

runsh: Total unexpected failed scenarios throughout the test run:
webUIDeleteFilesFolders/deleteFilesFolders.feature:77
webUIDeleteFilesFolders/deleteFilesFolders.feature:98

That is "unexpected" ;) - I need to investigate.

"old" oCIS had a .space folder by default in the personal space. This is gone by now. That explains that the two file counts decreased by 1, if I'm not mistaken.

@pascalwengerter
Copy link
Contributor

https://drone.owncloud.com/owncloud/web/22765/55/15

runsh: Total unexpected failed scenarios throughout the test run:
webUIDeleteFilesFolders/deleteFilesFolders.feature:77
webUIDeleteFilesFolders/deleteFilesFolders.feature:98

That is "unexpected" ;) - I need to investigate.

@kulmann and I did so already. Turns out there were two files in the filesList some weeks back, the Shares and the personal space's .space folder. Since the .space folder has been removed in oCIS, we need to reduce the amount of expected files in the list by one

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@phil-davis phil-davis marked this pull request as ready for review February 15, 2022 14:40
@phil-davis phil-davis requested a review from fschade as a code owner February 15, 2022 14:40
@phil-davis phil-davis merged commit 905b4e3 into master Feb 15, 2022
@delete-merged-branch delete-merged-branch bot deleted the bump-ocis-commit-id branch February 15, 2022 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants