Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only] mock files-spaces-personal-home route in SharedViaLink unit tests #6409

Conversation

individual-it
Copy link
Member

Description

mock the 'files-spaces-personal-home' route

@fshade you have added the route to the tests in d0b2b84, any reason we should not mock the route?

Related Issue

Motivation and Context

get rid of these log output:

  console.warn
    [vue-router] Route with name 'files-spaces-personal-home' does not exist

      at warn (node_modules/vue-router/dist/vue-router.common.js:18:47)
      at Object.match (node_modules/vue-router/dist/vue-router.common.js:1594:9)
      at VueRouter.match (node_modules/vue-router/dist/vue-router.common.js:2940:23)
      at VueRouter.resolve (node_modules/vue-router/dist/vue-router.common.js:3094:20)
      at Proxy.render (node_modules/vue-router/dist/vue-router.common.js:1099:22)
      at node_modules/@vue/composition-api/dist/vue-composition-api.common.js:1892:35
      at activateCurrentInstance (node_modules/@vue/composition-api/dist/vue-composition-api.common.js:1842:16)

How Has This Been Tested?

  • running unit-tests locally
  • 🤖

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@individual-it
Copy link
Member Author

CI failed with generate-ocis: Error response from daemon: No such image: owncloudci/nodejs:14 restarted

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@kulmann kulmann merged commit 4f26ff5 into master Feb 10, 2022
@delete-merged-branch delete-merged-branch bot deleted the reduceLogOutput/web-app-files/tests/unit/views/SharedViaLink.spec.js branch February 10, 2022 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants