-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tests-only] remove language related log outputs in unit-tests #6404
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks pretty neat already, but running yarn test:unit packages/web-app-files/tests/unit/views
there's still some No translations found for en_US from views that are not included in this PR. Is there a specific reason you left them out?
Awesome progress on the topic btw!
@pascalwengerter yes, those are form |
Any idea how to do that? |
Should be possible like this vuejs/vue-test-utils#450 (comment) - global mock would be nicer though 🤔 |
de8bba5
to
46aea07
Compare
Kudos, SonarCloud Quality Gate passed! |
@kulmann thank you for the tip, I've mocked it in 46aea07 please review again |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😍
Description
<translate>
in Projects.spec.js & LocationPicker.spec.jsRelated Issue
part of #6337
Motivation and Context
reduce log output in unit tests
How Has This Been Tested?
yarn run test:unit 2>&1 | wc -l
before this PR: 2641
after this PR: 583
Types of changes
Checklist:
Open tasks: