Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only] [full-ci] Adjust test to avoid issue 6305 #6319

Merged
merged 1 commit into from
Jan 26, 2022

Conversation

phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Jan 26, 2022

Description

Adjust the test for "delete all" batch action to take into account that the Shares folder cannot be deleted.
The test workflow now does "select all" and then unselects the Shares folder, then deletes the remaining items.

See issue comment #6305 (comment) and the other discussion in the issue.

Related Issue

#6305

How Has This Been Tested?

CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@phil-davis phil-davis self-assigned this Jan 26, 2022
@phil-davis phil-davis force-pushed the adjust-test-for-6305 branch from d0e91e9 to 2c1b5b0 Compare January 26, 2022 15:11
@phil-davis phil-davis marked this pull request as ready for review January 26, 2022 15:11
@owncloud owncloud deleted a comment from ownclouders Jan 26, 2022
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

@pascalwengerter pascalwengerter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine for me if CI turns green

@phil-davis phil-davis merged commit a577ecc into master Jan 26, 2022
@delete-merged-branch delete-merged-branch bot deleted the adjust-test-for-6305 branch January 26, 2022 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants