-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show version numbers #6190
Show version numbers #6190
Conversation
Results for oC10SharingAccept https://drone.owncloud.com/owncloud/web/21373/15/1
|
Results for oCISSharingBasic https://drone.owncloud.com/owncloud/web/21373/53/1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ❤️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to take a look at the code still, but yesterday was wondering if we should provide such information also to the user? Could live on the account
page in the runtime for example, e.g. in a details/summary HTML tag so very subtle yet also available for less techy users?
a45efab
to
a346b00
Compare
We discussed this during the refinement and basically said that we'll have to show a lot of versions in the future. Since every extension that gets loaded from an external source comes with its own version number we'll eventually want to show all of them, which might need a dedicated "about" page in the future. But still, showing the web ui version and the backend version somewhere visible in the UI makes a lot of sense, even then. I'll create a ticket for it after christmas... thank you for bringing it up again! :-) |
@kulmann rebasing on current master should make the smoke tests way more stable :) |
Could you do that for me? Not at my desk |
a346b00
to
d20feea
Compare
Sure thing, just done it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Kudos, SonarCloud Quality Gate passed! |
Results for oCISSharingPublic1 https://drone.owncloud.com/owncloud/web/21389/64/1
|
Results for oC10SharingExternal https://drone.owncloud.com/owncloud/web/21389/40/1
|
Results for oC10SharingPublic1 https://drone.owncloud.com/owncloud/web/21389/37/1
|
Description
With this PR the web ui prints the package version and the backend version (if available) to the javascript console and sets them as meta generator tag in the html head. See screenshots below. There are some (known) situations where the backend version is not available. Those need to be fixed separately, this PR just makes use of the information. Only consequence is that the backend doesn't show up, so it's not an issue to fix it separately. The version of the web ui always gets shown, as it is included in the bundling process.
The
product
key in the version doesn't exist, yet, so for now it'll always fall back toownCloud
. I'll provide an oCIS PR so that oCIS will announce itself asproduct: "oCIS"
in the future. For ownCloud 10 we don't need to change anything as the fallback is correct there.Related Issue
Motivation and Context
Make debugging and bug reports easier.
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: