Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let editors be default editors by default #6186

Merged
merged 1 commit into from
Dec 22, 2021
Merged

Conversation

kulmann
Copy link
Contributor

@kulmann kulmann commented Dec 21, 2021

Description

Editor apps that don't provide the information about whether or not they are a default editor were not recognized as default editors when left-clicking a file in the file list. We've changed the default behaviour so that editors are capable of being the default editor unless explicitly disabled.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Copy link
Contributor

@pascalwengerter pascalwengerter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, CI fails because of translations in integration tests..

@kulmann kulmann force-pushed the bugfix-app-defaults branch from e654cd4 to 6aa2e92 Compare December 22, 2021 08:48
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ownclouders
Copy link
Contributor

Results for oC10SharingAccept https://drone.owncloud.com/owncloud/web/21325/15/1
The following scenarios passed on retry:

  • webUISharingAcceptShares/acceptShares.feature:111

@kulmann kulmann merged commit 2e74edd into master Dec 22, 2021
@delete-merged-branch delete-merged-branch bot deleted the bugfix-app-defaults branch December 22, 2021 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants