-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[full-ci] refactor pagination into composable, cleanup store, views and tests #6065
Conversation
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
Results for oC10Basic https://drone.owncloud.com/owncloud/web/20505/12/1 |
…tialization every time
Results for oC10SharingAccept https://drone.owncloud.com/owncloud/web/20518/16/1
|
Results for oC10Files1 https://drone.owncloud.com/owncloud/web/20518/17/1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The duplication of pagination templates is a bit verbose. Could still live in a dedicated pagination
component with a few props. Would be more or less a template-only component. v-if
should be placed in the views like you have it now, not inside the component.
Please decide for yourself if you want to do that in this PR or in a separate one to get this awesome change going fast. 🚀
…a props instead of store
good point, done expect the outer if decision, i think in the case of this component where a pages of 0 is a potential displaying glitch its ok to have it battery included inside the component and let it decide on its own what to do. THANKS for your review ❤️ |
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😍
Description
See #6048
Related Issue
Motivation and Context
clean code ™️
How Has This Been Tested?
Types of changes
Checklist: