Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[full-ci] refactor pagination into composable, cleanup store, views and tests #6065

Merged
merged 4 commits into from
Nov 29, 2021

Conversation

fschade
Copy link
Contributor

@fschade fschade commented Nov 28, 2021

Description

See #6048

Related Issue

Motivation and Context

clean code ™️

How Has This Been Tested?

  • unit tests
  • integration tests

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added

@update-docs
Copy link

update-docs bot commented Nov 28, 2021

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@fschade fschade mentioned this pull request Nov 28, 2021
2 tasks
@ownclouders
Copy link
Contributor

Results for oC10Basic https://drone.owncloud.com/owncloud/web/20505/12/1
💥 The acceptance tests pipeline failed. The build has been cancelled.

@ownclouders
Copy link
Contributor

Results for oC10SharingAccept https://drone.owncloud.com/owncloud/web/20518/16/1
The following scenarios passed on retry:

  • webUISharingAcceptSharesToRoot/acceptShares.feature:108

@ownclouders
Copy link
Contributor

Results for oC10Files1 https://drone.owncloud.com/owncloud/web/20518/17/1
💥 The acceptance tests pipeline failed. The build has been cancelled.

@fschade fschade changed the title refactor pagination into composable, cleanup store, views and tests [full-ci] refactor pagination into composable, cleanup store, views and tests Nov 29, 2021
Copy link
Contributor

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The duplication of pagination templates is a bit verbose. Could still live in a dedicated pagination component with a few props. Would be more or less a template-only component. v-if should be placed in the views like you have it now, not inside the component.

Please decide for yourself if you want to do that in this PR or in a separate one to get this awesome change going fast. 🚀

@fschade
Copy link
Contributor Author

fschade commented Nov 29, 2021

The duplication of pagination templates is a bit verbose. Could still live in a dedicated pagination component with a few props. Would be more or less a template-only component. v-if should be placed in the views like you have it now, not inside the component.

Please decide for yourself if you want to do that in this PR or in a separate one to get this awesome change going fast. 🚀

good point, done expect the outer if decision, i think in the case of this component where a pages of 0 is a potential displaying glitch its ok to have it battery included inside the component and let it decide on its own what to do.

THANKS for your review ❤️

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

67.9% 67.9% Coverage
21.4% 21.4% Duplication

Copy link
Contributor

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍

@fschade fschade merged commit 9e1ebde into master Nov 29, 2021
@delete-merged-branch delete-merged-branch bot deleted the pagination-to-composable branch November 29, 2021 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants