A11y fix logical keyboard order #5982
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kulmann
reviewed
Nov 5, 2021
| @@ -9,7 +9,7 @@ | |||
| class="oc-files-file-link-edit oc-mr-xs" | |||
| @click="editLink" | |||
| > | |||
| <oc-icon name="edit" /> | |||
| <oc-icon id="editButtonLabel" name="edit" /> | |||
There was a problem hiding this comment.
Id is not unique, since this component exists once per link row. You need to add a unique qualifier to the id dynamically (e.g. the share id).
fschade
reviewed
Nov 11, 2021
| focusDatepicker() { | ||
| this.expireDate = null | ||
| this.$nextTick(() => { | ||
| console.log('DATEPICKER: ', this.$refs.datepicker) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Focus certain elements when clicking certain buttons (more detailed info in related issue).
Related Issue
How Has This Been Tested?
Types of changes
Checklist:
Open tasks:
svgelement inside ofOcIconcomponent, not sure how to target it. Also focussing via focus() method won't trigger the tooltip.document.getElementById('new-file-menu-btn').focus()doesn't have any effect, althougdocument.getElementById('new-file-menu-btn').click()is working.