Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export translations of search app #5956

Merged
merged 3 commits into from
Nov 11, 2021
Merged

Export translations of search app #5956

merged 3 commits into from
Nov 11, 2021

Conversation

kulmann
Copy link
Contributor

@kulmann kulmann commented Oct 28, 2021

Description

Fixes that the search app was not exporting its translations in the app manifest.

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@kulmann kulmann force-pushed the translations-search-app branch from 7b90469 to 14dd7b9 Compare October 29, 2021 06:20
pascalwengerter
pascalwengerter approved these changes Oct 29, 2021
View reviewed changes
Copy link
Contributor

@pascalwengerter pascalwengerter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code works and looks good, I'd be in favor of force-merging if the CI issues are unrelated/random. Thanks for taking care!

@kulmann kulmann force-pushed the translations-search-app branch 2 times, most recently from 35c6439 to 2f4b042 Compare November 10, 2021 14:01
@pascalwengerter pascalwengerter mentioned this pull request Nov 11, 2021
Closed
26 tasks
@ownclouders
Copy link
Contributor

Results for oCISSharingPermissions3 https://drone.owncloud.com/owncloud/web/20246/61/1
💥 The acceptance tests pipeline failed. The build has been cancelled.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@pascalwengerter
Copy link
Contributor

Results for oCISSharingPermissions3 https://drone.owncloud.com/owncloud/web/20246/61/1 boom The acceptance tests pipeline failed. The build has been cancelled.

Failed due to changes in master's drone config in the meantime, rebased so should run fine now

@ownclouders
Copy link
Contributor

Results for oCISSharingInternalUsers1 https://drone.owncloud.com/owncloud/web/20247/57/1
The following scenarios passed on retry:

  • webUISharingInternalUsers/shareWithUsers.feature:158

@ownclouders
Copy link
Contributor

Results for oC10SharingExternal https://drone.owncloud.com/owncloud/web/20247/41/1
The following scenarios passed on retry:

  • webUISharingExternal/federationSharing.feature:106

@pascalwengerter pascalwengerter merged commit 2f544d5 into master Nov 11, 2021
@delete-merged-branch delete-merged-branch bot deleted the translations-search-app branch November 11, 2021 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pascalwengerter pascalwengerter pascalwengerter approved these changes

@fschade fschade Awaiting requested review from fschade

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Search bar placeholder not translatable / translated
3 participants
@kulmann @ownclouders @pascalwengerter