Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App Provider #5712

Closed
wants to merge 8 commits into from
Closed

App Provider #5712

wants to merge 8 commits into from

Conversation

elizavetaRa
Copy link
Member

@elizavetaRa elizavetaRa commented Aug 20, 2021

Description

Added the function to open files of certain mimetypes with corresponding apps

Related Issue

cs3org/reva#1923

How Has This Been Tested?

  • test environment: qa.cernbox.cern.ch
  • test case: opening different files with Collabora and CodiMD

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • [ x] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • [x ] Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Done

  • Mimetypes list with applications gets retrieved on opening the frontend
  • The corresponding to the file mimetype apps are shown in the sidebar actions and the context menu actions
  • View for the applications opens in the new tab (new route apps/:app/:file_id), iframe with the app

Open tasks:

  • make a package for appprovider instead of implementation in the web-app-files package
  • Sharing button (opens sidebar sharing menu) in the top-bar in the application tab
  • Create files with different extensions and on creation open them with default application
  • (backend, in progress) default apps are first in the mimetypes list
  • (backend, in progress) fix bugs with Collabora, CodiMD, MS Office

@update-docs
Copy link

update-docs bot commented Aug 20, 2021

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@elizavetaRa elizavetaRa changed the title Appprovider App Provider Aug 20, 2021
@pascalwengerter
Copy link
Contributor

@elizavetaRa could you drop the CERN-specific stuff from this PR (e.g. feedback button in the left navbar) and add a "definition of done" for this PR?

@pascalwengerter
Copy link
Contributor

Closed in favor of #5805

@elizavetaRa elizavetaRa deleted the external_apps_pr branch May 31, 2023 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants