Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[full-ci][Tests-Only] Fix intermittent failure on user creation #5447

Merged
merged 1 commit into from
Jul 9, 2021

Conversation

dpakach
Copy link
Contributor

@dpakach dpakach commented Jul 5, 2021

Description

Because of a bug in user creation in ocis(owncloud/ocis#2272), few tests fail and only pass on retry.
eg #5463 (comment)
This Pr fixes that issue.

Related Issue

Motivation and Context

How Has This Been Tested?

🤖

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@dpakach dpakach marked this pull request as draft July 5, 2021 07:53
@dpakach dpakach force-pushed the remove-delete-shares branch from 5338c6d to 3c5c059 Compare July 5, 2021 08:12
@ownclouders
Copy link
Contributor

Results for oCISSharingInternalUsers2 https://drone.owncloud.com/owncloud/web/17062/53/1
💥 The acceptance tests pipeline failed. The build has been cancelled.

@dpakach dpakach changed the title [Tests-Only] remove delete shares after tests for ocis [full-ci][Tests-Only] remove delete shares after tests for ocis Jul 5, 2021
@dpakach dpakach force-pushed the remove-delete-shares branch from 3c5c059 to c31c2d9 Compare July 8, 2021 05:55
@dpakach dpakach changed the title [full-ci][Tests-Only] remove delete shares after tests for ocis [full-ci][Tests-Only] Fix intermittent failure on user creation Jul 8, 2021
@dpakach dpakach marked this pull request as ready for review July 8, 2021 06:00
@dpakach dpakach self-assigned this Jul 8, 2021
@dpakach dpakach added the QA:team label Jul 8, 2021
@ownclouders
Copy link
Contributor

Results for oC10iPhone1 https://drone.owncloud.com/owncloud/web/17157/44/1
The following scenarios passed on retry:

  • webUIDeleteFilesFolders/deleteFilesFolders.feature:59

@ownclouders
Copy link
Contributor

Results for oC10IntegrationApp2 https://drone.owncloud.com/owncloud/web/17157/65/1

💥 The acceptance tests failed. Please find the screenshots inside ...

webUISharingAutocompletion-shareAutocompletion-feature-32.png

webUISharingAutocompletion-shareAutocompletion-feature-32.png

webUISharingAutocompletion-shareAutocompletion-feature-44.png

webUISharingAutocompletion-shareAutocompletion-feature-44.png

@ownclouders
Copy link
Contributor

Results for oC10Sharing1 https://drone.owncloud.com/owncloud/web/17157/15/1

💥 The acceptance tests failed. Please find the screenshots inside ...

webUISharingAutocompletion-shareAutocompletion-feature-115.png

webUISharingAutocompletion-shareAutocompletion-feature-115.png

webUISharingAutocompletion-shareAutocompletion-feature-128.png

webUISharingAutocompletion-shareAutocompletion-feature-128.png

webUISharingAutocompletion-shareAutocompletion-feature-141.png

webUISharingAutocompletion-shareAutocompletion-feature-141.png

webUISharingAutocompletion-shareAutocompletion-feature-154.png

webUISharingAutocompletion-shareAutocompletion-feature-154.png

webUISharingAutocompletion-shareAutocompletion-feature-168.png

webUISharingAutocompletion-shareAutocompletion-feature-168.png

webUISharingAutocompletion-shareAutocompletion-feature-32.png

webUISharingAutocompletion-shareAutocompletion-feature-32.png

webUISharingAutocompletion-shareAutocompletion-feature-44.png

webUISharingAutocompletion-shareAutocompletion-feature-44.png

webUISharingAutocompletion-shareAutocompletion-feature-87.png

webUISharingAutocompletion-shareAutocompletion-feature-87.png

webUISharingAutocompletion-shareAutocompletionSpecialChars-feature-36.png

webUISharingAutocompletion-shareAutocompletionSpecialChars-feature-36.png

webUISharingAutocompletion-shareAutocompletionSpecialChars-feature-37.png

webUISharingAutocompletion-shareAutocompletionSpecialChars-feature-37.png

webUISharingAutocompletion-shareAutocompletionSpecialChars-feature-38.png

webUISharingAutocompletion-shareAutocompletionSpecialChars-feature-38.png

@ownclouders
Copy link
Contributor

Results for oC10IntegrationApp2 https://drone.owncloud.com/owncloud/web/17158/65/1

💥 The acceptance tests failed. Please find the screenshots inside ...

webUISharingAutocompletion-shareAutocompletion-feature-32.png

webUISharingAutocompletion-shareAutocompletion-feature-32.png

webUISharingAutocompletion-shareAutocompletion-feature-44.png

webUISharingAutocompletion-shareAutocompletion-feature-44.png

@ownclouders
Copy link
Contributor

Results for oC10Sharing1 https://drone.owncloud.com/owncloud/web/17158/15/1

💥 The acceptance tests failed. Please find the screenshots inside ...

webUISharingAutocompletion-shareAutocompletion-feature-115.png

webUISharingAutocompletion-shareAutocompletion-feature-115.png

webUISharingAutocompletion-shareAutocompletion-feature-128.png

webUISharingAutocompletion-shareAutocompletion-feature-128.png

webUISharingAutocompletion-shareAutocompletion-feature-141.png

webUISharingAutocompletion-shareAutocompletion-feature-141.png

webUISharingAutocompletion-shareAutocompletion-feature-154.png

webUISharingAutocompletion-shareAutocompletion-feature-154.png

webUISharingAutocompletion-shareAutocompletion-feature-168.png

webUISharingAutocompletion-shareAutocompletion-feature-168.png

webUISharingAutocompletion-shareAutocompletion-feature-32.png

webUISharingAutocompletion-shareAutocompletion-feature-32.png

webUISharingAutocompletion-shareAutocompletion-feature-44.png

webUISharingAutocompletion-shareAutocompletion-feature-44.png

webUISharingAutocompletion-shareAutocompletion-feature-87.png

webUISharingAutocompletion-shareAutocompletion-feature-87.png

webUISharingAutocompletion-shareAutocompletionSpecialChars-feature-36.png

webUISharingAutocompletion-shareAutocompletionSpecialChars-feature-36.png

webUISharingAutocompletion-shareAutocompletionSpecialChars-feature-37.png

webUISharingAutocompletion-shareAutocompletionSpecialChars-feature-37.png

webUISharingAutocompletion-shareAutocompletionSpecialChars-feature-38.png

webUISharingAutocompletion-shareAutocompletionSpecialChars-feature-38.png

@dpakach dpakach force-pushed the remove-delete-shares branch from c31c2d9 to 01aba2f Compare July 8, 2021 15:15
@dpakach dpakach requested a review from fschade as a code owner July 8, 2021 15:15
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 8, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@dpakach dpakach requested a review from individual-it July 9, 2021 02:59
Copy link
Member

@individual-it individual-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please make the same change in the test-middleware

@individual-it individual-it merged commit 567747b into master Jul 9, 2021
@delete-merged-branch delete-merged-branch bot deleted the remove-delete-shares branch July 9, 2021 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

issue creating user during test runs
3 participants